Skip to content

Fix: Backup timing and folder name handling #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patricioxavier8 merged 1 commit into from
Feb 2, 2026
Merged

Fix: Backup timing and folder name handling #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Shared/Services/Backups/BackupsService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,8 @@ class BackupsService: ObservableObject {

private func propagateUploadSuccess() {
logger.info("Device backed up successfully, tracking backup success event")
UserDefaults.standard.set(Date(), forKey: LAST_BACKUP_TIME_KEY)

DispatchQueue.main.async { [weak self] in
self?.backupUploadProgress = 1
self?.currentDeviceHasBackup = true
Expand Down
2 changes: 1 addition & 1 deletion SyncExtension/UseCases/All/GetFileOrFolderMetaUseCase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ struct GetFileOrFolderMetaUseCase {

let folderItem = FileProviderItem(
identifier: self.identifier,
filename: folderMeta.plainName,
filename: (folderMeta.plainName ?? folderMeta.name) ?? "",
parentId: parentId,
createdAt: createdAt,
updatedAt: updatedAt,
Expand Down
2 changes: 1 addition & 1 deletion SyncExtension/UseCases/All/Workspaces/GetFileOrFolderMetaWorkspaceUseCase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ struct GetFileOrFolderMetaWorkspaceUseCase {
let folderItem = FileProviderItem(
identifier: self.identifier,
// TODO: Decrypt the name if needed
filename: folderMeta.plainName,
filename: (folderMeta.plainName ?? folderMeta.name) ?? "",
parentId: parentId,
createdAt: createdAt,
updatedAt: updatedAt,
Expand Down
2 changes: 1 addition & 1 deletion SyncExtension/UseCases/Folders/GetFolderMetaUseCase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ struct GetFolderMetaUseCase {

let folderItem = FileProviderItem(
identifier: self.identifier,
filename: folderMeta.plainName,
filename: (folderMeta.name ?? folderMeta.plainName) ?? "",
parentId: parentId ,
createdAt: createdAt,
updatedAt: updateAt,
Expand Down