Fix C++ sonar analysis #1212
Merged
Fix C++ sonar analysis #1212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sg-gs
previously approved these changes
Dec 26, 2025
egalvis27
previously approved these changes
Dec 26, 2025
dajimenezriv-internxt
dismissed stale reviews from sg-gs and egalvis27
via
425eccb
| stopUpload(state); | ||
| return resolve(); | ||
| } | ||
| async function progressCallback(progress: number) { |
Contributor
Author
There was a problem hiding this comment.
This is just because a sonar error, since progressCalback accepts a sync function and we were sending an async function.
|
sg-gs
approved these changes
Jan 23, 2026
Member
sg-gs
left a comment
sg-gs
left a comment
There was a problem hiding this comment.
LGTM as long as we open another PR to keep the sonar analysis on the parts that have seen shutdown on this PR @dajimenezriv-internxt
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
For now we are going to disable the sonar analysis in the addon and the core packages, since they are pointing to their own repos when looking for PRs. In the code side everything is configured but commented.
Also, in windows we have pointed to the local core package instead of the published one, but we will keep the version for linux compatibility.