Skip to content

Fix sonar pipelines #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dajimenezriv-internxt wants to merge 3 commits into
base: main
Choose a base branch
from
+14 −16
Draft

Fix sonar pipelines #1257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a242ec
Fix sonar pipelines
dajimenezriv-internxt Jan 23, 2026
0fa72ba
Commit
dajimenezriv-internxt Jan 23, 2026
c0d481d
Commit
dajimenezriv-internxt Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions .github/workflows/addon-sonar-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Addon sonar analysis

on:
pull_request:
paths: ['packages/addon/**']
paths: ['packages/addon/**', '.github/workflows/**']
types: [opened, synchronize, reopened]
push:
paths: ['packages/addon/**']
Expand Down Expand Up @@ -36,10 +36,9 @@ jobs:
- name: Run build wrapper
run: build-wrapper-win-x86-64.exe --out-dir build_wrapper_output_directory cmd /c "node-gyp configure build"

# The sonar analysis does not work because the sonar project points to the node-win repo so it cannot find the PR
# - name: SonarQube Scan
# uses: SonarSource/sonarqube-scan-action@1a6d90ebcb0e6a6b1d87e37ba693fe453195ae25 # v5.3.1
# env:
# SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
# with:
# projectBaseDir: packages/addon
- name: SonarQube Scan
uses: SonarSource/sonarqube-scan-action@1a6d90ebcb0e6a6b1d87e37ba693fe453195ae25 # v5.3.1
env:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
with:
projectBaseDir: packages/addon
15 changes: 7 additions & 8 deletions .github/workflows/core-sonar-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Core sonar analysis

on:
pull_request:
paths: ['packages/core/**']
paths: ['packages/core/**', '.github/workflows/**']
types: [opened, synchronize, reopened]
push:
paths: ['packages/core/**']
Expand Down Expand Up @@ -33,10 +33,9 @@ jobs:
- name: Run tests
run: npm run test:cov

# The sonar analysis does not work because the sonar project points to the node-win repo so it cannot find the PR
# - name: SonarQube Scan
# uses: SonarSource/sonarqube-scan-action@1a6d90ebcb0e6a6b1d87e37ba693fe453195ae25 # v5.3.1
# env:
# SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
# with:
# projectBaseDir: packages/core
- name: SonarQube Scan
uses: SonarSource/sonarqube-scan-action@1a6d90ebcb0e6a6b1d87e37ba693fe453195ae25 # v5.3.1
env:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
with:
projectBaseDir: packages/core
Loading