[_] feat: allow empty files in workspace #833
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apsantiso
temporarily deployed
to
development
GitHub Actions
Inactive
apsantiso
temporarily deployed
to
development
GitHub Actions
Inactive
|
|
This PR is stale because it has been open for more than 15 days with no activity. |
jzunigax2
force-pushed
the
feat/allow-empty-files-workspaces
branch
from
2b284d1 to
2b1bd8a
Compare
|
jzunigax2
force-pushed
the
feat/allow-empty-files-workspaces
branch
from
c68879d to
36d20c6
Compare
jzunigax2
had a problem deploying
to
development
GitHub Actions
Failure
sg-gs
reviewed
Jan 29, 2026
| include: [ | ||
| { | ||
| model: WorkspaceItemUserModel, | ||
| where: { |
Contributor
There was a problem hiding this comment.
based on the following explain result yes
| QUERY PLAN |
|---|
| Aggregate (cost=5.05..5.06 rows=1 width=8) |
| -> Nested Loop (cost=1.00..5.05 rows=1 width=4) |
| -> Index Scan using workspace_items_users_workspace_creator_index on workspace_items_users "workspaceUser" (cost=0.42..2.45 rows=1 width=16) |
| Index Cond: ((workspace_id = '<worksapce uuid>'::uuid) AND ((created_by)::text = '<workspace user uuid>'::text)) |
| Filter: ((item_type)::text = 'file'::text) |
| -> Index Scan using files_uuid_key on files "FileModel" (cost=0.57..2.60 rows=1 width=20) |
| Index Cond: (uuid = "workspaceUser".item_id) |
| Filter: ((status <> 'DELETED'::enum_files_status) AND (size = 0)) |
…backup, file, and folder use cases
…o deleted folders
…o prevent null file_id entries
…ic logging and response
…ce network user empty file counts
jzunigax2
force-pushed
the
feat/allow-empty-files-workspaces
branch
from
93ad14e to
fe03a53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces per-member empty file limit checks when creating files in a workspace. The limit is enforced inside fileUseCases.createFile using the same workspaceOptions pattern already used by replaceFile, ensuring the check runs against the individual workspace member rather than the shared network user.