feat(migration): drop legacy unique index on folders table #883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This PR is stale because it has been open for more than 15 days with no activity. |
IMPORTANT: Delete all test records from file_versions table before running this migration: DELETE FROM file_versions WHERE 1=1;
jzunigax2
force-pushed
the
chore/drop-legacy-plainName-parentid-index
branch
from
a7561cd to
d6dfa6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Drop the legacy unique index
folders_plainname_parentid_keyfrom thefolderstable, now that the replacement indexfolders_parentuuid_plainname_uniquehas been deployed in PR #882.Why
1. Index is no longer used
The legacy index has not been scanned since 2026-01-07, when the optimized
idx_folders_user_parentuuid_plainname_not_deleted_removedindex was introduced.2. Redundant uniqueness enforcement
With PR #882 merged, we now have a proper unique constraint on
(parent_uuid, plain_name)that:findByNameAndParentUuid)The legacy index on
(plain_name, parent_id)is now fully redundant.3. Write performance impact
Despite not being scanned, the index is still maintained on every write operation.
4. Disk space recovery
Dropping this index reclaims 5,940 MB of disk space.
How
Migration uses
DROP INDEX CONCURRENTLYto avoid table locks: