[PB-5673] set name = plainName #898
Conversation
TamaraFinogina
had a problem deploying
to
development
GitHub Actions
Failure
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
had a problem deploying
to
development
GitHub Actions
Failure
TamaraFinogina
had a problem deploying
to
development
GitHub Actions
Failure
TamaraFinogina
had a problem deploying
to
development
GitHub Actions
Failure
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
| bucketId: string, | ||
| ): Promise<[Folder, Folder, Folder]> { | ||
| const rootFolderName = this.cryptoService.encryptName(`${v4()}`); | ||
| const rootFolderName = v4(); |
There was a problem hiding this comment.
I do not know the side effects of this case. A root folder's name should not be decrypted in any case, as there is no level above it and thus, it does not have any folders at its same level too.
LGTM assuming that, but double check it @jzunigax2
src/modules/folder/folder.usecase.ts
Outdated
|
|
||
| const folderWithSameNameExists = await this.folderRepository.findOne({ | ||
| name: cryptoFileName, | ||
| name: newFolderMetadata.plainName, |
There was a problem hiding this comment.
This could not be done, it's not consistent. The already existent items have their names encrypted. The new ones won't. You may introduce an OR here. Or even better: switch from findOne using the name to use the plainName, as we should deprecate this field.
There was a problem hiding this comment.
Switched to plainName for findOne: f713435
sg-gs
left a comment
sg-gs
left a comment
There was a problem hiding this comment.
Left some comments @TamaraFinogina
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
had a problem deploying
to
development
GitHub Actions
Failure
|
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
2 participants
This PR sets the name equal to plainName instead of its encrypted version.