-
Notifications
You must be signed in to change notification settings - Fork 4
[_]: feat/add migration to clean up duplicate folders #916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jzunigax2
wants to merge
3
commits into
master
Choose a base branch
from
chore/duplicate-folder-rename-script
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| 'use strict'; | ||
|
|
||
| const sleep = (ms) => new Promise((resolve) => setTimeout(resolve, ms)); | ||
| const MAX_ATTEMPTS = 10; | ||
| const BATCH_SIZE = 10; | ||
| const SLEEP_TIME_MS = 1000; | ||
|
|
||
| module.exports = { | ||
| up: async (queryInterface) => { | ||
| let totalRenamed = 0; | ||
| let batchCount = 0; | ||
| let attempts = 0; | ||
|
|
||
| console.info(`Batch size: ${BATCH_SIZE} duplicate folders per batch`); | ||
| console.info('Starting cleanup of duplicate folders...'); | ||
|
|
||
| console.info('Creating supporting index...'); | ||
| await queryInterface.sequelize.query(` | ||
| CREATE INDEX CONCURRENTLY IF NOT EXISTS folders_parentuuid_plainname_not_deleted_support_index | ||
| ON folders (parent_uuid, plain_name) | ||
| WHERE deleted = false AND removed = false; | ||
| `); | ||
|
|
||
| const renameQuery = ` | ||
| WITH duplicate_groups AS ( | ||
| SELECT parent_uuid, plain_name, MIN(id) as id_to_keep | ||
| FROM folders | ||
| WHERE deleted = false | ||
| AND removed = false | ||
| AND parent_uuid IS NOT NULL | ||
| AND plain_name IS NOT NULL | ||
| GROUP BY parent_uuid, plain_name | ||
| HAVING COUNT(*) > 1 | ||
| LIMIT ${BATCH_SIZE} | ||
| ) | ||
| UPDATE folders f | ||
| SET | ||
| plain_name = f.plain_name || '_' || f.id::text, | ||
| updated_at = NOW() | ||
| FROM duplicate_groups dg | ||
| WHERE f.parent_uuid = dg.parent_uuid | ||
| AND f.plain_name = dg.plain_name | ||
| AND f.id != dg.id_to_keep | ||
| AND f.deleted = false | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
| AND f.removed = false | ||
| RETURNING f.id; | ||
| `; | ||
|
|
||
| let hasMore = true; | ||
|
|
||
| while (hasMore) { | ||
| try { | ||
| const [results] = await queryInterface.sequelize.query(renameQuery); | ||
| const renamedInBatch = results.length; | ||
| batchCount++; | ||
| totalRenamed += renamedInBatch; | ||
| attempts = 0; | ||
|
|
||
| console.info( | ||
| `Batch ${batchCount}: Renamed ${renamedInBatch} folders (Total: ${totalRenamed})`, | ||
| ); | ||
|
|
||
| hasMore = renamedInBatch > 0; | ||
|
|
||
| if (hasMore) { | ||
| await sleep(SLEEP_TIME_MS); | ||
| } | ||
| } catch (err) { | ||
| attempts++; | ||
| console.error( | ||
| `[ERROR]: Error in batch ${batchCount} (attempt ${attempts}/${MAX_ATTEMPTS}): ${err.message}`, | ||
| ); | ||
|
|
||
| if (attempts >= MAX_ATTEMPTS) { | ||
| console.error( | ||
| '[ERROR]: Maximum retry attempts reached, exiting migration.', | ||
| ); | ||
| throw err; | ||
| } | ||
|
|
||
| await sleep(SLEEP_TIME_MS); | ||
| } | ||
| } | ||
|
|
||
| console.info('\n=== Cleanup Complete ==='); | ||
| console.info(`Total batches processed: ${batchCount}`); | ||
| console.info(`Total folders renamed: ${totalRenamed}`); | ||
|
|
||
| console.info('Dropping supporting index...'); | ||
| await queryInterface.sequelize.query(` | ||
| DROP INDEX CONCURRENTLY IF EXISTS folders_parentuuid_plainname_not_deleted_support_index; | ||
| `); | ||
| }, | ||
|
|
||
| down: async (queryInterface) => { | ||
| await queryInterface.sequelize.query(` | ||
| DROP INDEX CONCURRENTLY IF EXISTS folders_parentuuid_plainname_not_deleted_support_index; | ||
| `); | ||
| }, | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add removed = false from here also, as the indexes we should add and the issue we have, is with the existing folders in the same folder with the same name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done