-
Notifications
You must be signed in to change notification settings - Fork 4
[PB-5856] fix(file-versions): use file updated time as modification time for versions #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…tUpdatedAt" This reverts commit 7440c28.
|
sg-gs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad about contradicting you @jzunigax2, I have just realised about that. The modificationTime is the same field we use in files and in Unix-based OSes, it refers to precisely what @douglas-xt is explaining what is needed for in the description. If you want to rollback for the previous name, I will just approve it so we do not give more work to @douglas-xt.
Whatever you prefer @jzunigax2
|
@jzunigax2 confirmed it is okay as is, so, running migration @douglas-xt |
I do not recall adding this column, did you @jzunigax2 ? |
hey @douglas-xt I believe this is due to introducing a new column with allow null false but without a default value |
|
@sg-gs I think we need to truncate the entire file_version table to run this migration, similar to when we added the non-nullable user_id column. My bad, I didn't include this in the PR description. @jzunigax2 |



What does this PR do?
Why are we doing this?
How are we doing this?
file.updatedAtwhen creating file versionsShould this be manually tested & how?
Already tested via HTTP requests by creating a file, replacing it multiple times with different timestamps, and verifying each version displays the correct modification time when listing versions.
Any background context you want to provide?