-
Notifications
You must be signed in to change notification settings - Fork 33
[PB-5462] Version History UI (panel + menu entry) #1764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
terrerox
wants to merge
47
commits into
master
Choose a base branch
from
feature/file-version-history
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,227
−33
Open
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
1410020
feat: add version history menu item to drive context menu
terrerox 1090978
feat: implement version history sidebar for drive items
terrerox b4b5565
refactor: restructure version history sidebar with modular components
terrerox b1d81a3
refactor: rename version history dialog state and actions to sidebar
terrerox aea78d9
feat: add internationalization support to version history module
terrerox 3f2091e
refactor: simplify version history components and remove unused code
terrerox c47b83e
feature: implement file version history with restore, delete, and d…
terrerox 5d54b7e
refactor: update skeleton component to use Array.from for better read…
terrerox ac309af
feature: improve file version downloads with multipart support and …
terrerox 8c1579c
refactor: remove redundant error handling in version download
terrerox c5ba49e
feature: enhance internationalization for version management with add…
terrerox 3e31c8e
feature: enhance version history with batch operations and SDK inte…
terrerox 09f8a34
feature: refactor file upload logic and enhance version info handling…
terrerox 16ffd60
feature: update currentVersion state handling in Sidebar to reflect i…
terrerox efa5e40
feature: integrate versioning limits context and enhance version hi…
terrerox 87d41e4
feature: implement versioning limits context and enhance file replace…
terrerox 6b94c39
refactor: implement Redux-based caching for file versions and remov…
terrerox d8bb143
feature: enhance version history menu item to handle availability bas…
terrerox ba4ec35
refactor: improve file versions state management and naming convent…
terrerox 636c509
refactor: remove unused selectors from fileVersionsSelectors
terrerox 4e0af53
refactor: add default empty array return to getVersionsByFileId selector
terrerox 1eaed50
feature: add file extension validation for version replacement and im…
terrerox 054cf3f
refactor: add user avatar support and update border styling in versio…
terrerox 802d5a9
fix: add backdrop overlay to prevent dropdown hover bleed-through in …
terrerox 6c178b7
fix: pin version size label to the right edge
terrerox 08a4c95
test: add comprehensive test coverage for file version history feature
terrerox b6beafe
test: improve test descriptions using Given-When-Then pattern
terrerox 52bc06b
test: refine test descriptions for consistency and clarity
terrerox 7966f01
test: add unit tests for Redux file versions slice and version item a…
terrerox b9f976b
refactor: simplify test descriptions in file versions slice tests
terrerox 1c1f529
test: refactor test descriptions to use Given-When-Then pattern
terrerox 365e798
feat: add locked feature modal and versioning enhancements
terrerox 1708f3e
feat: add locked feature localization for multiple languages
terrerox 1e3e929
feature: update LockedFeatureModal styles and improve accessibility
terrerox c611ef5
feat: add timestamped filename format for version downloads
terrerox 3a2dea6
test: update date format in version item menu tests
terrerox 39fe918
feature: simplify download name generation for single items
terrerox aa07cc5
refactor: simplify handleUpgrade function in Sidebar component
terrerox 3bc8d3f
refactor: streamline LockedFeatureModal layout and remove unused styles
terrerox 469c291
style: enhance hover effect for unselected version item in dark mode
terrerox 7e2608c
style: adjust padding and text styles in LockedFeatureModal for impro…
terrerox 08e496b
fix: improve sidebar visibility logic by consolidating open state checks
terrerox 565ee07
feat: add loading state for file limits in Sidebar component
terrerox 330c14d
feat: implement smart polling for version limits after plan changes
terrerox b6c7ee7
fix: handle file extension correctly in version download filename
terrerox 808ae27
refactor: optimize version extension checking and clean up imports
terrerox 23b70f8
feature: filter expired versions and optimize re-renders in version h…
terrerox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You must add the translations for the other 7 languages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is necessary to mantain the old
trashAndUploadlogic or we can replace it with newreplace file logicfor all users?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to maintain the old logic for users who don’t have versioning enabled. You might ask: why not move this to the backend? That won’t be possible because the replace file endpoint is used by the CLI. If a user with versioning enabled creates another version and exceeds the limit, we need to permanently delete the older version of the file. That endpoint already handles this logic for the CLI, and now it’s being used for the web as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps that is the new desired behaviour. Please confirm with Product dept if the replacement behaviour is the new desired one :)
If not, we can leave it as it is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The replace file endpoint is open for everyone (including free users). Desktop, mobile, etc.
I think the same as Ramon, for me it makes more sense to actually replace the file always, as it is the expected behaviour (instead of trashing and uploading it again)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That approach falls under criteria #2 and #3 of this story