-
Notifications
You must be signed in to change notification settings - Fork 33
[PB-5649]: Add automatic trash disposal notification dialog #1798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
terrerox
wants to merge
5
commits into
master
Choose a base branch
from
feature/automatic-trash-disposal
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+256
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement an informational modal that notifies users about the new automatic trash disposal feature. The dialog displays tier-based retention periods (1 day for free users, 7 days for essential, 14 days for premium, and 30 days for ultimate users). - Create AutomaticTrashDisposalDialog component with responsive dark mode styling - Add UI state management for dialog visibility - Display modal only to existing users (excludes new signups) - Add translation keys for dialog content - Integrate dialog into Trash view with proper state handling
Deploying drive-web with
|
| Latest commit: |
c842340
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d4b02aea.drive-web.pages.dev |
| Branch Preview URL: | https://feature-automatic-trash-disp.drive-web.pages.dev |
CandelR
reviewed
Jan 8, 2026
src/views/Trash/Trash.tsx
Outdated
| import { userSelectors } from 'app/store/slices/user'; | ||
| import localStorageService from 'services/local-storage.service'; | ||
|
|
||
| const HAS_SEEN_TRASH_DISPOSAL_DIALOG_KEY = 'hasSeenTrashDisposalDialog'; |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to add the key with the rest of local storage ones
CandelR
approved these changes
Jan 9, 2026
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Description
Implement an informational modal that notifies users about the new automatic trash disposal
feature. The dialog displays tier-based retention periods (1 day for free users, 7 days for
essential, 14 days for premium, and 30 days for ultimate users).
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes