[PB-4450]: refactor/extract components from Share Dialog#1818
Merged
Conversation
Deploying drive-web with
|
| Latest commit: |
ed7319a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2536e658.drive-web.pages.dev |
| Branch Preview URL: | https://refactor-share-dialog-compon.drive-web.pages.dev |
larryrider
approved these changes
Jan 20, 2026
CandelR
reviewed
Jan 20, 2026
Collaborator
CandelR
left a comment
CandelR
left a comment
There was a problem hiding this comment.
Remember to check the list of description
Comment on lines
7
to
10
| userList; | ||
| invitedUsers: InvitedUserProps[]; | ||
| areInvitedUsersLoading: boolean; | ||
| user; |
| invitedUsers: InvitedUserProps[]; | ||
| areInvitedUsersLoading: boolean; | ||
| user; | ||
| openUserOptions: (e: any, user: InvitedUserProps, selectedIndex: number | null) => void; |
Collaborator
There was a problem hiding this comment.
avoid any always as possible
| import { useTranslationContext } from 'app/i18n/provider/TranslationProvider'; | ||
| import { AccessMode } from '../../types'; | ||
|
|
||
| export const LoadingState = ({ isLoading }: { isLoading: boolean }) => { |
Collaborator
There was a problem hiding this comment.
no need to export if is only used in this file
| import { Views } from '../types'; | ||
|
|
||
| interface HeaderProps { | ||
| itemToShare; |
…t/drive-web into refactor/share-dialog-components
…g-from-Share-dialog [_]: refactor/Share Dialog cleanup
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracting components from the Share Dialog component to organize them.
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes