Skip to content

[PB-4450]: feat/custom hooks for Share Dialog #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xabg2 merged 8 commits into from
Jan 27, 2026
Merged

[PB-4450]: feat/custom hooks for Share Dialog #1827

xabg2 merged 8 commits into from
Jan 27, 2026

Conversation

@xabg2
Copy link
Contributor

@xabg2 xabg2 commented Jan 23, 2026 •
edited
Loading

Description

Implementing the custom hooks that contains the logic for Share Dialog.

Related Issues

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

Additional Notes

@xabg2 xabg2 self-assigned this Jan 23, 2026
@xabg2 xabg2 added the enhancement New feature or request label Jan 23, 2026
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 23, 2026 •
edited
Loading

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: cf29d11
Status: ✅  Deploy successful!
Preview URL: https://231aa578.drive-web.pages.dev
Branch Preview URL: https://feature-share-dialog-custom.drive-web.pages.dev

View logs

@xabg2 xabg2 marked this pull request as ready for review January 23, 2026 09:04
@xabg2
Copy link
Contributor Author

xabg2 commented Jan 23, 2026

There is duplicated code because some functions are in the main component (Share Dialog) and the custom hooks. It will be resolved in the following PR

CandelR
CandelR approved these changes Jan 27, 2026
View reviewed changes
src/app/drive/components/ShareDialog/hooks/useShareItemActions.ts Outdated
interface ShareItemActionsProps {
itemToShare: ItemToShare | null;
isPasswordSharingAvailable: boolean;
dispatch: any;
Copy link
Collaborator

@CandelR CandelR Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the type :)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 27, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.9% Coverage on New Code
2.2% Duplication on New Code

See analysis details on SonarQube Cloud

@xabg2 xabg2 merged commit 43e17fa into master Jan 27, 2026
9 of 10 checks passed
@xabg2 xabg2 deleted the feature/share-dialog-custom-hooks branch January 27, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CandelR CandelR CandelR approved these changes

@larryrider larryrider Awaiting requested review from larryrider larryrider is a code owner

Assignees

@xabg2 xabg2

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xabg2 @CandelR