[BR-1794]: Enhance retry logic with server error handling and retry reason differentiation #1848
+194
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ason differentiation - Add RetryReason enum to distinguish between rate-limit and server-error retries - Extend retryable errors to include 5xx server errors, CORS errors, and network failures - Implement exponential backoff with jitter for server errors (1s base, max 10s) - Add HTTP status codes for 5xx errors (500, 502, 503, 504) to constants - Add CORS error message to ErrorMessages enum - Update onRetry callback signature to include RetryReason parameter - Refactor retry logic to remove redundant variables and magic strings - Update all retry callbacks across codebase to handle new RetryReason parameter - Add comprehensive test coverage for server error retries - Simplify error detection logic with named constants and helper functions
terrerox
requested review from
a team,
CandelR and
larryrider
as code owners
terrerox
changed the title
Deploying drive-web with
|
| Latest commit: |
c65f899
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://674a26fb.drive-web.pages.dev |
| Branch Preview URL: | https://feature-retry-with-backoff-s.drive-web.pages.dev |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes