[PB-5724] Cleanup the webworkers #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TamaraFinogina
changed the title
CandelR
reviewed
Feb 2, 2026
Comment on lines
868
to
908
| dispose() { | ||
| this._olmAdapter.clearMySession(); | ||
| this.clearAllSessions(); | ||
| this.conference.off( | ||
| JitsiConferenceEvents.USER_JOINED, | ||
| this._onParticipantJoined.bind(this), | ||
| ); | ||
| this.conference.off( | ||
| JitsiConferenceEvents.USER_LEFT, | ||
| this._onParticipantLeft.bind(this), | ||
| ); | ||
| this.conference.off( | ||
| JitsiConferenceEvents.ENDPOINT_MESSAGE_RECEIVED, | ||
| this._onEndpointMessageReceived.bind(this), | ||
| ); | ||
| this.conference.off( | ||
| JitsiConferenceEvents.CONFERENCE_LEFT, | ||
| this._onConferenceLeft.bind(this), | ||
| ); | ||
| this.conference.off(JitsiConferenceEvents.CONFERENCE_JOINED, this.onConferenceJoined.bind(this)); | ||
| this.conference.off( | ||
| JitsiConferenceEvents._MEDIA_SESSION_STARTED, | ||
| this._onMediaSessionStarted.bind(this), | ||
| ); | ||
| this.conference.off( | ||
| JitsiConferenceEvents.TRACK_ADDED, | ||
| this.onTrackAddedHandler.bind(this), | ||
| ); | ||
| this.conference.rtc.off( | ||
| RTCEvents.REMOTE_TRACK_ADDED, | ||
| this.onRemoteTrackAddedHandler.bind(this), | ||
| ); | ||
| this.conference.off( | ||
| JitsiConferenceEvents.TRACK_MUTE_CHANGED, | ||
| this._trackMuteChanged.bind(this), | ||
| ); | ||
| this.e2eeCtx.off('sasUpdated', this.sasUpdatedHandler); | ||
| this.e2eeCtx.dispose(); | ||
| this._reqs.clear(); | ||
| this.update.clear(); | ||
| } |
There was a problem hiding this comment.
The dispose() listener removal won't work due to .bind(this) creating new function references.
EventEmitter.removeListener() compares by reference. Each .bind(this) call creates a new function object, so the references passed to off() in dispose() don't match the ones registered with on() in the constructor and the listeners silently remain attached
Collaborator
Author
There was a problem hiding this comment.
oh, ok. Do you know how to remove .bind(this) listeners?
Collaborator
Author
There was a problem hiding this comment.
create and keep reference in the class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the connection fails due to a server or WebSocket error, several instances of web workers are created.
If the conference fails, it should clean up web workers, too
How Has This Been Tested?
During a call, switch from wi-fi to mobile internet to cause webSocket closed error. Or test when server is busy and terminates connections
Types of changes
Checklist: