Skip to content

Conversation

@dajimenezriv-internxt
Copy link
Contributor

@dajimenezriv-internxt dajimenezriv-internxt commented Jan 28, 2025

What

  1. Fix two production bugs that made drive icons not working properly and also was throwing an internal error. This is error was not going worse since probably the health check was restarting the thread again.
    image
  2. Improve register syncRoot for development.

Current behaviour

  1. In node-win we had a watcher that performed some actions. Among those actions, were the hydrate and dehydrate. When we were performing the action hydrate, it was working right and when we were performing the action dehydrate it was getting called two times. However, the real problem was when double click on the file and fetching data. Doing that, we were triggering the fetch data but also the hydrate event from the watcher, which shouldn't happen. This made the drive icons stayed in iddle and it seemed that we never fetched the data. It also was throwing an internal error.

New behaviour

  1. Now, we found that the stats of a file contain an attribute called blocks. Based on the value of blocks, we know if the action called is hydrate, fetch data or if it's the second call to dehydrate.
  2. We have improved the register in development so we can develop faster. This register command creates a syncRoot folder in which we can perform some operations like add, delete, hydrate, dehydrate, fetch data... With these changes we don't need neither the environment variables, so we can remove .env.

@sg-gs
Copy link
Member

sg-gs commented Jan 28, 2025

I have a question regarding this one

With these changes we don't need neither the environment variables, so we can remove .env.

If the environment variables are removed, how are you configuring where the sync root is set @dajimenezriv ?

This register command creates a syncRoot folder

@dajimenezriv-internxt dajimenezriv-internxt removed the request for review from cg27shokworks January 28, 2025 12:08
@dajimenezriv-internxt dajimenezriv-internxt marked this pull request as draft January 28, 2025 12:38
@dajimenezriv-internxt
Copy link
Contributor Author

Since this syncRoot is just for the example, now the logs and the syncRoot will be inside the examples folder, in a tmp folder, so everything is there together, and we do not need to place logs in AppData or the syncRoot in the Documents folder. Also from visual studio we will be able to check the logs and syncRoot faster. @sg-gs

@dajimenezriv-internxt dajimenezriv-internxt marked this pull request as ready for review January 28, 2025 17:38
@dajimenezriv-internxt dajimenezriv-internxt merged commit d6b3dee into master Jan 28, 2025
1 check passed
@dajimenezriv-internxt dajimenezriv-internxt deleted the improve-example-register branch January 28, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants