Refactor: Virtual Drive Initialization Improvements #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and disconnecting
dajimenezriv-internxt
requested changes
Feb 13, 2025
src/addon-wrapper.ts
Outdated
| } | ||
|
|
||
| connectSyncRoot({ callbacks }: { callbacks: Callbacks }) { | ||
| connectSyncRoot({ callbacks }: { callbacks: Callbacks; syncRootPath: string }) { |
Contributor
There was a problem hiding this comment.
Le has añadido el parametro pero no se usa
dajimenezriv-internxt
requested changes
Feb 13, 2025
src/virtual-drive.ts
Outdated
| } | ||
|
|
||
| return addon.connectSyncRoot({ callbacks: this.callbacks }); | ||
| console.log("Connecting to sync root: ", this.syncRootPath); |
Contributor
There was a problem hiding this comment.
Why are these console.logs important?
src/virtual-drive.ts
Outdated
|
|
||
| const connectionKey = this.addon.connectSyncRoot({ callbacks: this.callbacks }); | ||
|
|
||
| console.log("Connection key: ", connectionKey); |
Contributor
There was a problem hiding this comment.
And this console.log
src/virtual-drive.unit.test.ts
Outdated
| const drive = new VirtualDrive(syncRootPath, logPath); | ||
| const providerId = v4(); | ||
|
|
||
| const drive = new VirtualDrive(syncRootPath, logPath, providerId); |
Contributor
There was a problem hiding this comment.
Here, you have changed the order of params.
We should move the drive and all things from now to start using object props to remove this problems:
internxt/drive-desktop#545
…and update constructor parameter order
dajimenezriv-internxt
approved these changes
Feb 13, 2025
ArceDanielShok
deleted the
chore/improve-sync-engine-and-virtual-drive
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR enhances the configuration and initialization process of the Virtual Drive, ensuring better stability and synchronization handling.
🔹 Implemented Changes: