Check pr size

.gitattributes

@@ -0,0 +1 @@
+* text=auto eol=crlf

.github/workflows/publish.yml

@@ -3,7 +3,7 @@ on:
   release:
     types: [created]
   workflow_dispatch:
-  
+
 jobs:
   build-windows:
     runs-on: windows-latest
@@ -12,7 +12,7 @@ jobs:
       packages: write
     steps:
       - uses: actions/checkout@v2
-      - run: yarn build:gyp 
+      - run: yarn build:gyp
       - uses: actions/upload-artifact@v2
         with:
           name: windows-binaries
@@ -32,11 +32,11 @@ jobs:
           path: build/Release
       - uses: actions/setup-node@v2
         with:
-          node-version: '16.x'
-          registry-url: 'https://npm.pkg.github.com'
+          node-version: "16.x"
+          registry-url: "https://npm.pkg.github.com"
       - run: yarn
         env:
-            NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - run: yarn publish
         env:
           NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/pull-request.yml

@@ -1,11 +1,11 @@
-name: Some pull request checks
+name: Pull request checks
 
 on:
   pull_request:
 
 jobs:
-  type-check:
-    runs-on: ubuntu-latest
+  checks:
+    runs-on: windows-latest
 
     steps:
       - name: Checkout code
@@ -16,11 +16,19 @@ jobs:
         with:
           node-version: 18
 
+      - name: Check PR size
+      - uses: maidsafe/pr_size_checker@v2
+        with:
+          max_lines_changed: 500
+
       - name: Install dependencies
         run: yarn install --ignore-scripts
 
       - name: Run TypeScript compiler
         run: yarn tsc
 
-      # - name: Run Vitest
-      #   run: yarn vitest:once
+      - name: Run Prettier
+        run: yarn prettier . --check
+
+      - name: Run tests
+        run: yarn test:once

examples/drive.ts

@@ -3,5 +3,5 @@ import VirtualDrive from "@/virtual-drive";
 
 import settings from "./settings";
 
-export const drive = new VirtualDrive(settings.syncRootPath, settings.defaultLogPath);
+export const drive = new VirtualDrive(settings.syncRootPath, settings.providerid, settings.defaultLogPath);
 export const logger = createLogger(settings.defaultLogPath);

examples/populate.ts

@@ -1,9 +1,9 @@
-import VirtualDrive from "@/virtual-drive";
-
 import { execSync } from "child_process";
 import { join } from "path";
 import { v4 } from "uuid";
 
+import VirtualDrive from "@/virtual-drive";
+
 import settings from "./settings";
 
 const rootFileName1 = v4();

examples/register.ts

@@ -20,7 +20,7 @@ const handlers = { handleAdd, handleHydrate, handleDehydrate, handleChangeSize }
 const notify = { onTaskSuccess: async () => undefined, onTaskProcessing: async () => undefined };
 const queueManager = new QueueManager(handlers, notify, settings.queuePersistPath);
 
-drive.registerSyncRoot(settings.driveName, settings.driveVersion, settings.providerid, callbacks, settings.iconPath);
+drive.registerSyncRoot(settings.driveName, settings.driveVersion, callbacks, settings.iconPath);
 drive.connectSyncRoot();
 
 try {
@@ -29,5 +29,5 @@ try {
 } catch (error) {
   logger.error(error);
   drive.disconnectSyncRoot();
-  VirtualDrive.unregisterSyncRoot(settings.syncRootPath);
+  drive.unregisterSyncRoot();
 }

examples/unregister.ts

@@ -1,7 +1,7 @@
 import VirtualDrive from "@/virtual-drive";
 
+import { drive } from "./drive";
 import { deleteInfoItems } from "./info-items-manager";
-import settings from "./settings";
 
-VirtualDrive.unregisterSyncRoot(settings.syncRootPath);
+drive.unregisterSyncRoot();
 deleteInfoItems();

examples/utils.ts

@@ -1,47 +1,46 @@
-import fs from 'fs';
-import path from 'path';
+import fs from "fs";
+import path from "path";
 
 interface FileDetail {
-    path: string;
-    size: number;
-    baseDir: string;
+  path: string;
+  size: number;
+  baseDir: string;
 }
 
 function readFilesRecursively(dir: string, fileList: FileDetail[] = []): FileDetail[] {
-    fs.readdirSync(dir).forEach(file => {
-        const filePath = path.join(dir, file);
-        if (fs.statSync(filePath).isDirectory()) {
-            readFilesRecursively(filePath, fileList);
-        } else {
-            fileList.push({
-                path: filePath,
-                size: fs.statSync(filePath).size,
-                baseDir: dir
-            });
-        }
-    });
-    return fileList;
+  fs.readdirSync(dir).forEach((file) => {
+    const filePath = path.join(dir, file);
+    if (fs.statSync(filePath).isDirectory()) {
+      readFilesRecursively(filePath, fileList);
+    } else {
+      fileList.push({
+        path: filePath,
+        size: fs.statSync(filePath).size,
+        baseDir: dir,
+      });
+    }
+  });
+  return fileList;
 }
 
 function createFilesWithSize(sourceFolder: string, destFolder: string): void {
-    const files: FileDetail[] = readFilesRecursively(sourceFolder);
+  const files: FileDetail[] = readFilesRecursively(sourceFolder);
 
-    if (!fs.existsSync(destFolder)) {
-        fs.mkdirSync(destFolder, { recursive: true });
-    }
-
-    files.forEach(file => {
-        const relativePath = path.relative(file.baseDir, file.path);
-        const destFilePath = path.join(file.baseDir.replace(sourceFolder, destFolder), relativePath);//path.join(destFolder, relativePath);
-        const destFileDir = file.baseDir.replace(sourceFolder, destFolder);//path.dirname(destFilePath);
+  if (!fs.existsSync(destFolder)) {
+    fs.mkdirSync(destFolder, { recursive: true });
+  }
 
-        if (!fs.existsSync(destFileDir)){
-            fs.mkdirSync(destFileDir, { recursive: true });
-        }
+  files.forEach((file) => {
+    const relativePath = path.relative(file.baseDir, file.path);
+    const destFilePath = path.join(file.baseDir.replace(sourceFolder, destFolder), relativePath); //path.join(destFolder, relativePath);
+    const destFileDir = file.baseDir.replace(sourceFolder, destFolder); //path.dirname(destFilePath);
 
-        fs.writeFileSync(destFilePath, Buffer.alloc(file.size));
-    });
+    if (!fs.existsSync(destFileDir)) {
+      fs.mkdirSync(destFileDir, { recursive: true });
+    }
 
+    fs.writeFileSync(destFilePath, Buffer.alloc(file.size));
+  });
 }
 
-export { createFilesWithSize };
+export { createFilesWithSize };

examples/utils/generate-random-file-tree.ts

@@ -1,8 +1,9 @@
-import VirtualDrive from '@/virtual-drive';
-import { v4 as uuidv4 } from 'uuid';
+import { v4 as uuidv4 } from "uuid";
+
+import VirtualDrive from "@/virtual-drive";
 
 interface GenerateOptions {
-  rootPath: string
+  rootPath: string;
   depth: number;
   filesPerFolder: number;
   foldersPerLevel: number;
@@ -26,18 +27,7 @@ function randomNormal(mean: number, stdDev: number): number {
 }
 
 function getRandomExtension(): string {
-  const extensions = [
-    ".txt",
-    ".pdf",
-    ".rar",
-    ".jpg",
-    ".docx",
-    ".xlsx",
-    ".mp4",
-    ".mkv",
-    ".json",
-    ""
-  ];
+  const extensions = [".txt", ".pdf", ".rar", ".jpg", ".docx", ".xlsx", ".mp4", ".mkv", ".json", ""];
   const index = Math.floor(Math.random() * extensions.length);
   return extensions[index];
 }
@@ -47,17 +37,11 @@ async function createStructureRecursively(
   currentPath: string,
   level: number,
   options: GenerateOptions,
-  result: Record<string, string>
+  result: Record<string, string>,
 ): Promise<void> {
   if (level < 0) return;
 
-  const {
-    filesPerFolder,
-    foldersPerLevel,
-    meanSize,
-    stdDev,
-    timeOffset
-  } = options;
+  const { filesPerFolder, foldersPerLevel, meanSize, stdDev, timeOffset } = options;
 
   for (let i = 0; i < filesPerFolder; i++) {
     const fileName = `file_${generateRandomId()}${getRandomExtension()}`;
@@ -69,13 +53,7 @@ async function createStructureRecursively(
     const createdAt = Date.now() - (timeOffset || 0);
     const updatedAt = Date.now() - (timeOffset || 0) + 2000;
 
-    drive.createFileByPath(
-      fullPath,
-      fileId,
-      fileSize,
-      createdAt,
-      updatedAt
-    );
+    drive.createFileByPath(fullPath, fileId, fileSize, createdAt, updatedAt);
 
     result[fileId] = fullPath;
   }
@@ -88,22 +66,13 @@ async function createStructureRecursively(
     const createdAt = Date.now() - (timeOffset || 0) - 10000; // Ejemplo
     const updatedAt = Date.now() - (timeOffset || 0);
 
-    drive.createFolderByPath(
-      newFolderPath,
-      folderId,
-      1000,
-      createdAt,
-      updatedAt
-    );
+    drive.createFolderByPath(newFolderPath, folderId, 1000, createdAt, updatedAt);
 
     await createStructureRecursively(drive, newFolderPath, level - 1, options, result);
   }
 }
 
-async function generateRandomFilesAndFolders(
-  drive: VirtualDrive,
-  options: GenerateOptions
-): Promise<Record<string, string>> {
+async function generateRandomFilesAndFolders(drive: VirtualDrive, options: GenerateOptions): Promise<Record<string, string>> {
   const { rootPath } = options;
 
   const result: Record<string, string> = {};
@@ -114,4 +83,4 @@ async function generateRandomFilesAndFolders(
 }
 
 export { generateRandomFilesAndFolders };
-export type { GenerateOptions }
+export type { GenerateOptions };

gyp.config.json

@@ -1,7 +1,7 @@
 {
-    "gyp_file": "binding.gyp",
-    "source_dirs": ["native-src/**/*.cpp"], 
-    "ignored_source_dirs": [],
-    "include_dirs": ["include"],
-    "ignored_include_dirs": []
-}
+  "gyp_file": "binding.gyp",
+  "source_dirs": ["native-src/**/*.cpp"],
+  "ignored_source_dirs": [],
+  "include_dirs": ["include"],
+  "ignored_include_dirs": []
+}

include/sync_root_interface/SyncRoot.h

@@ -16,11 +16,13 @@ class SyncRoot
 public:
     static HRESULT RegisterSyncRoot(const wchar_t *syncRootPath, const wchar_t *providerName, const wchar_t *providerVersion, const GUID &providerId, const wchar_t *logoPath);
     static HRESULT ConnectSyncRoot(const wchar_t *syncRootPath, InputSyncCallbacks syncCallbacks, napi_env env, CF_CONNECTION_KEY *connectionKey);
-    static HRESULT DisconnectSyncRoot();
-    static HRESULT UnregisterSyncRoot();
-    static std::list<ItemInfo> GetItemsSyncRoot(const wchar_t *syncRootPath);
+    static HRESULT DisconnectSyncRoot(const wchar_t *syncRootPath);
+    static HRESULT UnregisterSyncRoot(const GUID &providerId);
     static std::string GetFileIdentity(const wchar_t *path);
     static void HydrateFile(const wchar_t *filePath);
     static void DehydrateFile(const wchar_t *filePath);
     static void DeleteFileSyncRoot(const wchar_t *path);
+
+private:
+    CF_CONNECTION_KEY connectionKey;
 };