Skip to content

chore: detect memory leaks and check handlers #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cg27shokworks wants to merge 2 commits into from
Closed

chore: detect memory leaks and check handlers #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cd0321
chore: clean up
cg27shokworks Mar 26, 2025
a0d655b
chore: fix function name
cg27shokworks Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/virtual_drive/Wrappers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ napi_value ConnectSyncRootWrapper(napi_env env, napi_callback_info args);
napi_value CreateEntryWrapper(napi_env env, napi_callback_info args);
napi_value DisconnectSyncRootWrapper(napi_env env, napi_callback_info args);
napi_value GetFileIdentityWrapper(napi_env env, napi_callback_info args);
napi_value addLoggerPathWrapper(napi_env env, napi_callback_info args);
napi_value AddLoggerPathWrapper(napi_env env, napi_callback_info args);
napi_value UpdateSyncStatusWrapper(napi_env env, napi_callback_info args);
napi_value GetPlaceholderStateWrapper(napi_env env, napi_callback_info args);
napi_value GetPlaceholderWithStatePendingWrapper(napi_env env, napi_callback_info args);
Expand Down
2 changes: 1 addition & 1 deletion native-src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ napi_value init(napi_env env, napi_value exports)
napi_property_descriptor addLoggerPathDesc = {
"addLoggerPath",
nullptr,
addLoggerPathWrapper,
AddLoggerPathWrapper,
nullptr,
nullptr,
nullptr,
Expand Down
1 change: 0 additions & 1 deletion native-src/sync_root_interface/Utilities.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ void Utilities::AddFolderToSearchIndexer(_In_ PCWSTR folder)
winrt::check_hresult(searchCrawlScopeManager->AddDefaultScopeRule(url.data(), TRUE, FOLLOW_FLAGS::FF_INDEXCOMPLEXURLS));
winrt::check_hresult(searchCrawlScopeManager->SaveAll());

// wprintf(L"Succesfully called AddFolderToSearchIndexer on \"%s\"\n", url.data());
}
catch (...)
{
Expand Down
60 changes: 2 additions & 58 deletions native-src/virtual_drive/Wrappers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,6 @@ napi_value CreateEntryWrapper(napi_env env, napi_callback_info args)
return result;
}

// disconection wrapper
napi_value DisconnectSyncRootWrapper(napi_env env, napi_callback_info args)
{
size_t argc = 1;
Expand Down Expand Up @@ -500,7 +499,7 @@ napi_value DeleteFileSyncRootWrapper(napi_env env, napi_callback_info args)
return nullptr;
}

napi_value addLoggerPathWrapper(napi_env env, napi_callback_info args)
napi_value AddLoggerPathWrapper(napi_env env, napi_callback_info args)
{
size_t argc = 1;
napi_value argv[1];
Expand Down Expand Up @@ -763,62 +762,7 @@ napi_value HydrateFileWrapper(napi_env env, napi_callback_info args)

return promise;
}
// napi_value HydrateFileWrapper(napi_env env, napi_callback_info args) {
// size_t argc = 1;
// napi_value argv[1];
// napi_value thisArg;
// napi_get_cb_info(env, args, &argc, argv, &thisArg, nullptr);

// if (argc < 1) {
// napi_throw_type_error(env, nullptr, "The file path is required for HydrateFile");
// return nullptr;
// }

// // Obtener el argumento de JavaScript y convertirlo a una cadena de C++
// size_t pathLength;
// napi_get_value_string_utf16(env, argv[0], nullptr, 0, &pathLength);
// std::wstring fullPath(pathLength, L'\0');
// napi_get_value_string_utf16(env, argv[0], reinterpret_cast<char16_t *>(&fullPath[0]), pathLength + 1, nullptr);

// // Crear una promesa
// napi_deferred deferred;
// napi_value promise;
// napi_create_promise(env, &deferred, &promise);

// // Crear un handle scope para manejar la creación de objetos V8
// napi_handle_scope handleScope;
// napi_open_handle_scope(env, &handleScope);

// // Usar un bloque de manejo de V8
// {
// v8::Isolate* isolate = v8::Isolate::GetCurrent();
// v8::HandleScope scope(isolate);

// try {
// Logger::getInstance().log("init... " + Logger::fromWStringToString(fullPath.c_str()), LogLevel::INFO);
// SyncRoot::HydrateFile(fullPath.c_str());

// napi_value result;
// napi_get_undefined(env, &result);
// napi_resolve_deferred(env, deferred, result);
// } catch (const std::exception& e) {
// napi_value error;
// napi_create_string_utf8(env, e.what(), NAPI_AUTO_LENGTH, &error);
// napi_reject_deferred(env, deferred, error);
// } catch (...) {
// napi_value error;
// napi_create_string_utf8(env, "Unknown error", NAPI_AUTO_LENGTH, &error);
// napi_reject_deferred(env, deferred, error);
// }
// }

// // Cerrar el handle scope
// napi_close_handle_scope(env, handleScope);

// return promise;
// }

// Wrapper for DehydrateFile

napi_value DehydrateFileWrapper(napi_env env, napi_callback_info args)
{
size_t argc = 1;
Expand Down