Skip to content

fix: improve error handling in DehydrateFile for file in use scenarios #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cg27shokworks merged 1 commit into from
May 6, 2025
Merged

fix: improve error handling in DehydrateFile for file in use scenarios #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion native-src/sync_root_interface/SyncRoot.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,21 @@ void SyncRoot::DehydrateFile(const wchar_t *filePath)

if (FAILED(hr))
{
wprintf(L"Error dehydrating file %ls\n", filePath);
DWORD err = HRESULT_CODE(hr);
if (err == ERROR_SHARING_VIOLATION || err == ERROR_CLOUD_FILE_IN_USE)
{
wprintf(L"Cannot dehydrate because the file is currently in use: %ls\n", filePath);

MessageBoxW(
nullptr,
L"Unable to free up space because the file is currently in use.\nPlease close the file and try again.",
L"File in use",
MB_OK | MB_ICONWARNING | MB_SYSTEMMODAL);
}
else
{
wprintf(L"Error dehydrating file %ls\n", filePath);
}
// Logger::getInstance().log("Error dehydrating file " + Logger::fromWStringToString(filePath), LogLevel::ERROR);
}
else
Expand Down
Loading