Skip to content

Improve error handling and update file size limit in GetPlaceholderWithStatePending #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArceDanielShok merged 2 commits into from
May 23, 2025
Merged

Improve error handling and update file size limit in GetPlaceholderWithStatePending #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f632d7
Improve error handling and update file size limit in GetPlaceholderWi…
ArceDanielShok May 23, 2025
9138ccd
Bump version to 1.0.17 in package.json
ArceDanielShok May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 27 additions & 15 deletions native-src/placeholders_interface/Planceholders.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,29 +497,41 @@ std::vector<std::wstring> Placeholders::GetPlaceholderWithStatePending(const std
{
std::vector<std::wstring> resultPaths;

for (const auto &entry : std::filesystem::directory_iterator(directoryPath))
try
{
const auto &path = entry.path().wstring();

if (entry.is_directory())
{
std::vector<std::wstring> subfolderPaths = GetPlaceholderWithStatePending(path);
resultPaths.insert(resultPaths.end(), subfolderPaths.begin(), subfolderPaths.end());
}
else if (entry.is_regular_file())
for (const auto &entry : std::filesystem::directory_iterator(directoryPath, std::filesystem::directory_options::skip_permission_denied))
{
FileState placeholderState = Placeholders::GetPlaceholderInfo(path);
bool isFileValidForSync = (placeholderState.syncstate == SyncState::Undefined || placeholderState.syncstate == SyncState::NotInSync);
if (isFileValidForSync && IsFileValidForSync(path))
const auto &path = entry.path().wstring();

if (entry.is_directory())
{
FileState folderState = Placeholders::GetPlaceholderInfo(path);

if (folderState.syncstate == SyncState::Undefined || folderState.syncstate == SyncState::NotInSync)
{
std::vector<std::wstring> subfolderPaths = GetPlaceholderWithStatePending(path);
resultPaths.insert(resultPaths.end(), subfolderPaths.begin(), subfolderPaths.end());
}
}
else if (entry.is_regular_file())
{
resultPaths.push_back(path);
FileState placeholderState = Placeholders::GetPlaceholderInfo(path);

bool isFileValidForSync = (placeholderState.syncstate == SyncState::Undefined || placeholderState.syncstate == SyncState::NotInSync);
if (isFileValidForSync && IsFileValidForSync(path))
{
resultPaths.push_back(path);
}
}
}
}
catch (const std::exception &e)
{
wprintf(L"[GetPlaceholderWithStatePending] Error: %s\n", e.what());
}

return resultPaths;
}

bool Placeholders::IsFileValidForSync(const std::wstring &filePath)
{
// Obtener un handle al archivo
Expand Down Expand Up @@ -553,7 +565,7 @@ bool Placeholders::IsFileValidForSync(const std::wstring &filePath)
}

LARGE_INTEGER maxFileSize;
maxFileSize.QuadPart = 20LL * 1024 * 1024 * 1024; // 20GB
maxFileSize.QuadPart = 40LL * 1024 * 1024 * 1024; // 20GB

if (fileSize.QuadPart > maxFileSize.QuadPart)
{
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@internxt/node-win",
"version": "1.0.16",
"version": "1.0.17",
"description": "Drive desktop node addon",
"main": "dist/index.js",
"types": "dist/index.d.ts",
Expand Down