Skip to content

Remove rename or move from C++ #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dajimenezriv-internxt merged 2 commits into from
Jul 10, 2025
Merged

Remove rename or move from C++ #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a83161
Remove rename from C++
dajimenezriv-internxt Jul 1, 2025
84da009
Update package.json
dajimenezriv-internxt Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@
"native-src/sync_root_interface/callbacks/FetchData/TransferContext.cpp",
"native-src/sync_root_interface/callbacks/FetchPlaceholder/FetchPlaceholder.cpp",
"native-src/sync_root_interface/callbacks/NotifyDelete/NotifyDeleteCallback.cpp",
"native-src/sync_root_interface/callbacks/NotifyRename/NotifyRenameCallback.cpp",
"native-src/sync_root_interface/callbacks/NotifyRename/RenameTransferContext.cpp",
"native-src/virtual_drive/Wrappers.cpp"
],
"include_dirs": [
Expand Down
Binary file modified dist/addon.node
View file
Open in desktop
Binary file not shown.
25 changes: 0 additions & 25 deletions include/sync_root_interface/RenameTransferContext.h
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions include/sync_root_interface/callbacks/Callbacks.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ void register_threadsafe_callbacks(napi_env env, InputSyncCallbacks input);
void register_threadsafe_notify_delete_callback(const std::string &resource_name, napi_env env, InputSyncCallbacks input);
void CALLBACK notify_delete_callback_wrapper(_In_ CONST CF_CALLBACK_INFO *callbackInfo, _In_ CONST CF_CALLBACK_PARAMETERS *callbackParameters);

// Rename Callback
void register_threadsafe_notify_rename_callback(const std::string &resource_name, napi_env env, InputSyncCallbacks input);
void CALLBACK notify_rename_callback_wrapper(_In_ CONST CF_CALLBACK_INFO *callbackInfo, _In_ CONST CF_CALLBACK_PARAMETERS *callbackParameters);

// Fetch Placeholders Callback
void register_threadsafe_fetch_placeholders_callback(const std::string &resource_name, napi_env env, InputSyncCallbacks input);
void CALLBACK fetch_placeholders_callback_wrapper(_In_ CONST CF_CALLBACK_INFO *callbackInfo, _In_ CONST CF_CALLBACK_PARAMETERS *callbackParameters);
Expand Down
2 changes: 0 additions & 2 deletions include/sync_root_interface/callbacks/CallbacksContext.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,5 @@ struct InputSyncCallbacks {
napi_ref notify_dehydrate_completion_callback_ref;
napi_ref notify_delete_callback_ref;
napi_ref notify_delete_completion_callback_ref;
napi_ref notify_rename_callback_ref;
napi_ref notify_rename_completion_callback_ref;
napi_ref none_callback_ref;
};
1 change: 0 additions & 1 deletion include/types/ProcessTypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ enum class FileOperationError
{
UPLOAD_ERROR,
DOWNLOAD_ERROR,
RENAME_ERROR,
DELETE_ERROR,
METADATA_READ_ERROR
};
1 change: 0 additions & 1 deletion native-src/sync_root_interface/SyncRoot.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,6 @@ HRESULT SyncRoot::ConnectSyncRoot(const wchar_t *syncRootPath, InputSyncCallback

CF_CALLBACK_REGISTRATION callbackTable[] = {
{CF_CALLBACK_TYPE_NOTIFY_DELETE, notify_delete_callback_wrapper},
{CF_CALLBACK_TYPE_NOTIFY_RENAME, notify_rename_callback_wrapper},
{CF_CALLBACK_TYPE_FETCH_PLACEHOLDERS, fetch_placeholders_callback_wrapper},
{CF_CALLBACK_TYPE_FETCH_DATA, fetch_data_callback_wrapper},
{CF_CALLBACK_TYPE_CANCEL_FETCH_DATA, cancel_fetch_data_callback_wrapper},
Expand Down
2 changes: 0 additions & 2 deletions native-src/sync_root_interface/Utilities.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,6 @@ std::wstring Utilities::FileOperationErrorToWString(FileOperationError error)
return L"UPLOAD_ERROR";
case FileOperationError::DOWNLOAD_ERROR:
return L"DOWNLOAD_ERROR";
case FileOperationError::RENAME_ERROR:
return L"RENAME_ERROR";
case FileOperationError::DELETE_ERROR:
return L"DELETE_ERROR";
case FileOperationError::METADATA_READ_ERROR:
Expand Down
1 change: 0 additions & 1 deletion native-src/sync_root_interface/callbacks/Callbacks.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
void register_threadsafe_callbacks(napi_env env, InputSyncCallbacks input)
{
register_threadsafe_notify_delete_callback("NotifyDeleteThreadSafe", env, input);
register_threadsafe_notify_rename_callback("NotifyRenameThreadSafe", env, input);
register_threadsafe_fetch_data_callback("FetchDataThreadSafe", env, input);
register_threadsafe_cancel_fetch_data_callback("CancelFetchDataThreadSafe", env, input);
}
153 changes: 0 additions & 153 deletions native-src/sync_root_interface/callbacks/NotifyRename/NotifyRenameCallback.cpp
View file
Open in desktop

This file was deleted.

31 changes: 0 additions & 31 deletions native-src/sync_root_interface/callbacks/NotifyRename/RenameTransferContext.cpp
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions native-src/virtual_drive/Wrappers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,6 @@ napi_value ConnectSyncRootWrapper(napi_env env, napi_callback_info args)
InputSyncCallbacks callbacks = {};

napi_value notifyDeleteCompletionCallback;
napi_value notifyRenameCallback;
napi_value fetchDataCallback;
napi_value cancelFetchDataCallback;

Expand All @@ -334,19 +333,6 @@ napi_value ConnectSyncRootWrapper(napi_env env, napi_callback_info args)
return nullptr;
}

if (napi_get_named_property(env, argv[1], "notifyRenameCallback", &notifyRenameCallback) == napi_ok)
{
napi_create_reference(env, notifyRenameCallback, 1, &callbacks.notify_rename_callback_ref);
}

napi_valuetype valuetype_rename;
napi_status type_status_rename = napi_typeof(env, notifyRenameCallback, &valuetype_rename);
if (type_status_rename != napi_ok || valuetype_rename != napi_function)
{
napi_throw_error(env, nullptr, "notifyRenameCallback should be a function.");
return nullptr;
}

if (napi_get_named_property(env, argv[1], "fetchDataCallback", &fetchDataCallback) == napi_ok)
{
napi_create_reference(env, fetchDataCallback, 1, &callbacks.fetch_data_callback_ref);
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@internxt/node-win",
"version": "1.0.18",
"version": "1.0.19",
"description": "Drive desktop node addon",
"main": "dist/index.js",
"types": "dist/index.d.ts",
Expand Down