Extract get registered sync roots#190
Merged
dajimenezriv-internxt merged 21 commits intomasterfrom Sep 17, 2025
Merged
Conversation
| @@ -0,0 +1,28 @@ | |||
| #include "stdafx.h" | |||
Contributor
Author
There was a problem hiding this comment.
This function returns an array of SyncRoots. We obtain them from windows using winrt and iterate them obtaining their info.
| } | ||
|
|
||
| napi_value get_registered_sync_roots_wrapper(napi_env env, napi_callback_info args) { | ||
| std::vector<SyncRoots> roots = get_registered_sync_roots(); |
Contributor
Author
There was a problem hiding this comment.
Now we just parse the sync roots obtained before to a napi vector that javascript can understand.
| if (contextBuffer) { | ||
| sr.context = winrt::CryptographicBuffer::ConvertBinaryToString(winrt::BinaryStringEncoding::Utf8, contextBuffer).c_str(); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Previously here we were filtering by context using #inxt#, however now we do this filter in javascript using the displayName and the path instead.
cg-shokworks
previously approved these changes
Sep 16, 2025
dajimenezriv-internxt
dismissed
cg-shokworks’s stale review
The base branch was changed.
egalvis27
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.