Refactor unregister sync root#191
Merged
dajimenezriv-internxt merged 27 commits intomasterfrom Sep 17, 2025
Merged
Conversation
Base automatically changed from
extract-get-registered-sync-roots
to
master
September 17, 2025 14:59
|
|
||
| try { | ||
| return fn(env, info); | ||
| } catch (const winrt::hresult_error& e) { |
Contributor
Author
There was a problem hiding this comment.
Improve it to handle windows cloud api errors so we can print correctly the errors.
| auto contextBuffer = info.Context(); | ||
| if (contextBuffer) { | ||
| sr.context = winrt::CryptographicBuffer::ConvertBinaryToString(winrt::BinaryStringEncoding::Utf8, contextBuffer).c_str(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
We no longer need the context of the cloud provider since now we are filtering by the displayName and path.
| syncRootIdentity.append(providerName); | ||
|
|
||
| winrt::IBuffer contextBuffer = winrt::CryptographicBuffer::ConvertStringToBinary(syncRootIdentity, winrt::BinaryStringEncoding::Utf8); | ||
| info.Context(contextBuffer); |
Contributor
Author
There was a problem hiding this comment.
As said, we were adding the context when registering the cloud provider to filter later, however now we filter using the displayName and path.
| @@ -0,0 +1,19 @@ | |||
| #include <windows.h> | |||
Contributor
Author
There was a problem hiding this comment.
This is the new unregister. Basically now we don't care if it's an uuid, the "syncRoot" text or whatever. We assume that was javascript sends here is a existing sync root, which it should.
cg-shokworks
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.