Refactor dehydrate file#193
Merged
dajimenezriv-internxt merged 34 commits intomasterfrom Sep 18, 2025
Merged
Conversation
| @@ -0,0 +1,39 @@ | |||
| #include <windows.h> | |||
Contributor
Author
There was a problem hiding this comment.
Code is nearly the same.
- We check if it's a directory, in that case we throw an exception. Previously we were just ignoring it.
- We remove the check of a file has the attribute FILE_ATTRIBUTE_UNPINNED since the error given by
CfDehydratePlaceholderis better: [DehydrateFileWrapper] WinRT error: The operation cannot be performed on pinned cloud files. (HRESULT: 0x80070188). - We keep the mssage box in case the file is used in that moment and we cannot dehydrate.
- We throw the exception to let the javascript code know that something failed.
I've tested these three possible errors and all work perfectly.
| LARGE_INTEGER length; | ||
| GetFileSizeEx(placeholder.get(), &length); | ||
|
|
||
| if (attrib & FILE_ATTRIBUTE_UNPINNED) |
Contributor
Author
There was a problem hiding this comment.
We neo longer need to check this manually, the error given by CfDehydratePlaceholder is better as explained below.
egalvis27
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.