Improve connect and disconnect sync root #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
egalvis27
requested changes
Nov 4, 2025
|
|
||
| CF_CONNECTION_KEY connectionKey; | ||
| HRESULT hr = SyncRoot::ConnectSyncRoot(syncRootPath.c_str(), callbacks, env, &connectionKey); | ||
| SyncRoot::ConnectSyncRoot(syncRootPath.c_str(), callbacks, env); |
There was a problem hiding this comment.
Why is the possible error that this function may return no longer being handled?
| auto [syncRootPath] = napi_extract_args<std::wstring>(env, info); | ||
|
|
||
| HRESULT result = SyncRoot::DisconnectSyncRoot(syncRootPath.c_str()); | ||
| SyncRoot::DisconnectSyncRoot(syncRootPath.c_str()); |
There was a problem hiding this comment.
Is it not necessary to handle the error here?
Comment on lines
39
to
+41
| HRESULT hr = CfDisconnectSyncRoot(it->second); | ||
| if (SUCCEEDED(hr)) | ||
| { | ||
| connectionMap.erase(it); | ||
| } | ||
| return hr; | ||
|
|
||
| winrt::check_hresult(hr); |
There was a problem hiding this comment.
We need the variable hr?, why not do it as in previous revisions?
winrt::check_hresult(CfDisconnectSyncRoot(it->second));
Comment on lines
22
to
+29
| HRESULT hr = CfConnectSyncRoot( | ||
| syncRootPath, | ||
| callbackTable, | ||
| nullptr, | ||
| CF_CONNECT_FLAG_REQUIRE_PROCESS_INFO | CF_CONNECT_FLAG_REQUIRE_FULL_FILE_PATH, | ||
| connectionKey); | ||
|
|
||
| wprintf(L"Connection key: %llu\n", connectionKey->Internal); | ||
| &connectionKey); | ||
|
|
||
| if (SUCCEEDED(hr)) | ||
| { | ||
| connectionMap[syncRootPath] = *connectionKey; | ||
| } | ||
| winrt::check_hresult(hr); |
There was a problem hiding this comment.
We need the variable hr?, why not do it as in previous revisions?
winrt::check_hresult(CfConnectSyncRoot(
syncRootPath,
callbackTable,
nullptr,
CF_CONNECT_FLAG_REQUIRE_PROCESS_INFO | CF_CONNECT_FLAG_REQUIRE_FULL_FILE_PATH,
&connectionKey));
| napi_throw_error(env, nullptr, "Failed to define properties"); | ||
| return nullptr; | ||
| } | ||
| napi_define_properties(env, exports, property_count, properties); |
There was a problem hiding this comment.
Why is it no longer necessary to take this error into account?
egalvis27
approved these changes
Nov 4, 2025
dajimenezriv-internxt
deleted the
improve-connect-and-disconnect-sync-root
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
dehydrate_fileandhydrate_filewith our custom file handlerPlaceholders::OpenFileHandle.connect_sync_rootanddisconnect_sync_rooterror handling to throw an error usingwinrt::check_hresultinstead of returning an error.handleForPathwith our custom file handlerPlaceholders::OpenFileHandle.