-
Notifications
You must be signed in to change notification settings - Fork 1
Modify fetch data #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Modify fetch data #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sg-gs
reviewed
Nov 6, 2025
sg-gs
reviewed
Nov 6, 2025
sg-gs
reviewed
Nov 6, 2025
sg-gs
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


What
Currently we were using two different contexts for
fetch dataandcancel fetch data, each one with its own mutex. However, the mutex of thecancel fetch datawas just to printing a line when the cancel was finished.Now, we are going to use the same context between both, so the flow is going to be as follow.
fetch datais going to be called when do double click on a file or right click and "Always keep on this device".connectionKeyand thetransferKey(theconnectionKeyis the same for all transfers). This context is created usingCreateTransferContextfromTransferContext.cpp.fetchDatafunction in javascript from C++ passing as props the path and a callback to send the chunks. Also, we set the mutex of the context to wait until the fetch data is completed or is cancelled.cancel fetch data, we just call the functioncancelFetchDatain javascript from C++ passsing as prop the path so we can stop the download in javascript. It also unlocks the mutex of the context.