Skip to content

feat: transfer context#97

Merged
cg27shokworks merged 8 commits intomasterfrom
feat/transfer-context
Jan 29, 2025
Merged

feat: transfer context#97
cg27shokworks merged 8 commits intomasterfrom
feat/transfer-context

Conversation

@cg27shokworks
Copy link
Contributor

@cg27shokworks cg27shokworks commented Jan 21, 2025 •
edited
Loading

What

  • Removal of global variables for download management.
  • Replacement of global variables with an individual download context for each operation.

Why

  • Enables future parallel downloads without interference between them.
  • Prevents errors caused by mixing chunks from different downloads.
  • Separates code based on the executing thread, enhancing readability and maintainability.
  • Facilitates independent management of each download, ensuring that each process has its own environment and state.

@cg27shokworks cg27shokworks self-assigned this Jan 21, 2025
@cg27shokworks cg27shokworks marked this pull request as ready for review January 29, 2025 13:17
@cg27shokworks cg27shokworks merged commit caefc38 into master Jan 29, 2025
1 check passed
@cg27shokworks cg27shokworks deleted the feat/transfer-context branch January 29, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dajimenezriv-internxt dajimenezriv-internxt Awaiting requested review from dajimenezriv-internxt dajimenezriv-internxt is a code owner

1 more reviewer

@ArceDanielShok ArceDanielShok ArceDanielShok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cg27shokworks cg27shokworks

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cg27shokworks @ArceDanielShok