Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR adds the generated openapi types and client so we don't have to duplicate everything. I've run this command to generate just the needed types (get usage and get limit) and replace the implementations to check that they work:
oapi-codegen -package schema -generate types,client \ -include-operation-ids "UserController_getUserUsage,UserController_limit" \ http://localhost:3004/api-json > schema/schema.gen.goI've fixed also the tests since I changed the funcionality and added the library
https://github.com/stretchr/testifyto simplify the testing operation. It was just a check to see if the library makes sense. Feel free to change anything of this branch. (This library is also included in the rclone package).