-
Notifications
You must be signed in to change notification settings - Fork 12
[MKT-739]:feat/update banners from temp mail #1776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…/website into feat/business-LP-update
| <Image | ||
| src={getImage(`/banners/Ban_Internxt_160x600_en.jpg`)} | ||
| alt="BitDefender Vertical Banner" | ||
| src={getImage(`/banners/temp-email 160x600 EN.png`)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really working with spaces and this name? it is weird haha
| <div className="flex w-full flex-col items-center justify-center"> | ||
| <Image | ||
| src={getImage(`/banners/Ban_Internxt_728x90_en.jpg`)} | ||
| src={getImage(`/banners/temp-email 728x90 EN.png`)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Man these names are weird
| <div className="flex w-full flex-col items-center justify-center pt-6"> | ||
| <Image | ||
| src={getImage(`/banners/Ban_Internxt_728x90_en.jpg`)} | ||
| src={getImage(`/banners/temp-email 728x90 EN.png`)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated image filenames and converted them to .webp. I'm using these specific names because Cloudflare was having issues with hyphens.
next-env.d.ts
Outdated
| /// <reference types="next/image-types/global" /> | ||
| /// <reference types="next/navigation-types/compat/navigation" /> | ||
| import "./.next/types/routes.d.ts"; | ||
| import "./.next/dev/types/routes.d.ts"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems it was automatically updated during a yarn command. We are reverting to the previous version
…/website into feat/business-LP-update
|


This PR introduces new own banners on the temp mail LP, we hidded days ago the ones from bitdefender, now we use own banners that redirect to our home page