Improve handling of debugging WebSocket messages #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjsjohnmurray
previously approved these changes
Oct 26, 2023
|
@gjsjohnmurray @jpa95 @GendronAC I fixed the build error so you can now download this vsix to test the change if you want. |
gjsjohnmurray
approved these changes
Oct 26, 2023
|
I installed it and ran a few hundreds testcase without issue :) #HappyDance |
|
Working great on my specific use case as well. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server generally tries to send one "line" of console output per WebSocket "packet" when debugging. However, in cases where an extreme amount of output is written to the console in a short amount of time , the server may send a 32K chunk of many "lines". Currently our debug adapter chokes on that huge packet and throws an error, and the debugger becomes out of sync with the server. This PR fixes that.