Skip to content

Add signature validation to REST.ZAUTHENTICATE #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add signature validation to REST.ZAUTHENTICATE #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions rtn/REST.ZAUTHENTICATE.mac
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
ROUTINE REST.ZAUTHENTICATE
ZAUTHENTICATE(ServiceName, Namespace, Username, Password, Credentials, Properties) Public
{
#include %occErrors
Expand Down Expand Up @@ -34,7 +35,11 @@ ZAUTHENTICATE(ServiceName, Namespace, Username, Password, Credentials, Propertie
// if the access token is not a JWT, we would need to validate the access token
// using another means such as the introspection or userinfo endpoint.
if $$$ISOK(sc) {
set valid=##class(%SYS.OAuth2.Validation).ValidateJWT(applicationName,accessToken,,,.jsonObject,,.sc)
set valid=##class(%SYS.OAuth2.Validation).ValidateJWT(applicationName,accessToken,,,.jsonObject,.securityParams,.sc)
set isTokenSigned = $Data(securityParams("sigalg"))#2
if 'isTokenSigned {
$$$ThrowStatus($System.Status.Error($$$AccessDenied))
}
}

if valid {
Expand All @@ -53,10 +58,10 @@ ZAUTHENTICATE(ServiceName, Namespace, Username, Password, Credentials, Propertie
set Properties("FullName")="OAuth account "_Username
set Properties("Username")=Username
set Properties("Password")="" // we don't really care about oauth2 account password
.

// Set the roles and other Properties as appropriate.
set Properties("Roles")=roles
.

} else {
set errorText=$system.Status.GetErrorText(sc)
}
Expand Down