Conversation
isc-pbarton
force-pushed
the
csp-deploy
branch
from
a9f912a to
2c5bc8e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #839 +/- ##
==========================================
+ Coverage 49.03% 49.78% +0.74%
==========================================
Files 24 24
Lines 3271 3274 +3
==========================================
+ Hits 1604 1630 +26
+ Misses 1667 1644 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if '(##class(%File).CopyFile(srcFile, cspFile, 1)) { | ||
| set sc = $$$ERROR($$$GeneralError, "Unable to import '"_srcFile_"'") | ||
| if '(##class(%File).CopyFile(srcFile, cspFile, 1, .ret)) { | ||
| set sc = $$$ERROR($$$GeneralError,"Unable to copy CSP file from "_srcFile_" to "_cspFile_": return code "_ret) |
There was a problem hiding this comment.
Since this applies to XSLT files too, I would change the language to something more generic. Suggestion: "Unable to copy application file from ..."
| Quit ##super(initvalue) | ||
| set ..WebAppPath = ##class(%File).TempFilename()_"d" | ||
| do ##class(%File).CreateDirectoryChain(..WebAppPath) | ||
| do ..CreateTestWebApp("/csp/git/unittest/xsl", ..WebAppPath) |
There was a problem hiding this comment.
When I've done things like this (where a test case creates a record, testing a DTL, etc...), I find storing it in a class parameter helps improve code readability and makes it more explicit that this name should not change across the execution of the test case.
|
I didn't realize my comments had not been submitted. :( |
4 participants
Fixes #828
Fixes #669