Fix miscellaneous problems in enable
#682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isc-kiyer
reviewed
Jan 6, 2025
isc-shuliu
requested review from
isc-kiyer,
isc-tleavitt,
isc-eneil,
isc-jili and
isc-jlechtne
isc-kiyer
reviewed
Jan 6, 2025
| Set exactIPMVer = $Piece($Piece(fileName, "ipm-", 2, *), ".xml", 1, *-1) | ||
| Set ipmLocalArray(exactIPMVer) = fileName | ||
| Set menuList($Increment(menuList)) = exactIPMVer_" (local version)" | ||
| If ##class(%File).DirectoryExists(XMLDir) { |
There was a problem hiding this comment.
Is this XMLDir something we have decided as the kitted location of IPM when shipping with IRIS?
There was a problem hiding this comment.
@isc-tleavitt Can you confirm that? (I think you wrote that directory)
There was a problem hiding this comment.
I think this goes back to before my time. This is (per earlier context) /<instance install dir>/lib/ipm/ which seems reasonable to me.
isc-kiyer
approved these changes
Jan 6, 2025
isc-tleavitt
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ##676
This will fix miscellaneous problems in
enable