V0.10.x feat init cpf merge #703
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isc-kiyer
reviewed
Jan 13, 2025
There was a problem hiding this comment.
@isc-shuliu I know this is still a draft but was curious so took a look and left a few comments
| @@ -0,0 +1,3 @@ | |||
| [config] | |||
There was a problem hiding this comment.
Would recommend testing things like package mappings, roles, resources, web apps etc.
|
|
||
| Set pResourceHandled = 1 | ||
| } Catch ex { | ||
| Set pResourceHandled = 0 |
There was a problem hiding this comment.
For error handling, should see if the error is helpful if the user doesn't have the appropriate permissions and/or doesn't have %System_Callout privileges. Not sure how easy it is to have tests as different users with different privileges but worth adding if possible
isc-tleavitt
requested changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #631