[Hygiene] Remove severity check

[the-glu]

Should close #404 at this point :)

Mostly a revert of #968 (expect the rights fix)

[mickmis]

Now that everything has been migrated, removing this check sounds good, but we should also IMO avoid introducing in the future any more of those cases.
The easiest way to do so would probably be to remove the severity parameter in record_fail and raise an exception if the severity is not set in the documentation:

monitoring/monitoring/uss_qualifier/scenarios/scenario.py

Lines 113 to 128 in 2f4a376

	def record_failed(
	self,
	summary: str,
	severity: Optional[Severity] = None,
	details: str = "",
	query_timestamps: Optional[List[datetime]] = None,
	additional_data: Optional[dict] = None,
	) -> None:
	self._outcome_recorded = True
	if severity is None:
	if "severity" in self._documentation and self._documentation.severity:
	severity = self._documentation.severity
	else:
	raise ValueError(
	f"Severity of check '{self._documentation.name}' was not specified at failure time and is not documented in scenario documentation"
	)

[the-glu]

Now that everything has been migrated, removing this check sounds good, but we should also IMO avoid introducing in the future any more of those cases. The easiest way to do so would probably be to remove the severity parameter in record_fail and raise an exception if the severity is not set in the documentation:

The problem is that is still used for some legit reasons, like test and severity not in the documentation :/

Would renaming it to something else would do the trick ? Like _severity so it's shouldn't be used by convention :P

[mickmis]

The problem is that is still used for some legit reasons, like test and severity not in the documentation :/

I cannot find any use of the parameter anywhere else than in unit tests. Am I missing some?
And if it used only in unit tests, then that is not a legit use. Instead the unit tests could specify the severity through the TestCheckDocumentation simulating the fact that the severity was set through the documentation.
WDYT?

[the-glu]

I cannot find any use of the parameter anywhere else than in unit tests. Am I missing some? And if it used only in unit tests, then that is not a legit use. Instead the unit tests could specify the severity through the TestCheckDocumentation simulating the fact that the severity was set through the documentation. WDYT?

Ha correct, mixed up contexts between TestCheckDocumentation and record_failled, will do some cleanup :)

[mickmis]

Nice thanks!