[uss_qualifier/scenarios/netrid/misbehavior] Add checks for SP too large area search (NET0250) #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test step to the RID misbehavior scenario to finalize checking NET0250 started in #821.
Note that to keep the scenario steps simple and distinct, the service providers flights urls are fetched two times from the DSS during the scenario. An alternative would have been to load them in a separate step which would have required a polling step which is more expensive in terms of time than calling twice the DSS.
Merging the
unauthenticatedandinvalid search areasteps have been considered, however it would have required to either merge the checks in a single step, or check results after polling and capturing the information, which introduces a certain level of complexity, which do not seem to be required at this point. Clarity of the test scenario has been privileged. Happy to revisit this based on reviewers input.