[uss_qualifier/scenarios/netrid/misbehavior] Add checks for invalid credentials (NET0210) #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR looks good to me. As a sidenote, this scenario is a little bit older and is not entirely following the convention of "one action, one step": instead of having all the checks as part of the This is not a request for changing this PR, but just a note so you don't take this scenario as a reference :) |
monitoring/uss_qualifier/scenarios/astm/netrid/v19/misbehavior.md
Outdated
Show resolved
Hide resolved
…redentials (NET0210)
the-glu
force-pushed
the
misbehaviour-incorrect-credentials
branch
from
b498a7a to
8240b78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two steps in misbehavior scenario to ensure invalid credentials (and not only missing credentials) return authentication failures, as stated in #874