New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[uss_qualifier/scenarios/netrid/dss/isa_subscription_interactions] specify some check severity in test scenario documentation only (contrib #404) #884

Open

the-glu wants to merge 1 commit into interuss:main from Orbitalize:move-severity-check-2

+72 −88

Contributor

the-glu commented Jan 14, 2025

This PR follows PR #882

It does migrate more severity into scenario documentation, mainly for netrid/dss/isa_subscription_interactions, but does include others moves for some shared functions used in isa_subscription_interactions.

the-glu force-pushed the move-severity-check-2 branch from 6bfaaf3 to f36ba64 Compare

January 15, 2025 15:31

the-glu commented

View reviewed changes

Contributor Author

the-glu left a comment

I commented with some suggestions to move from high to medium based on description / current knowledge of the tests, please feel free to close those that are wrong :)

monitoring/uss_qualifier/scenarios/astm/netrid/v19/dss/isa_subscription_interactions.md

               If that ISA cannot be deleted, the **[astm.f3411.v19.DSS0030,d](../../../../../requirements/astm/f3411/v19.md)** requirement to implement the ISA deletion endpoint might not be met.
-              #### Response to the deletion of the ISA contains subscription ID check
+              #### 🛑 Response to the deletion of the ISA contains subscription ID check

Contributor Author

the-glu Jan 15, 2025

This one can probably be moved to Medium?

monitoring/uss_qualifier/scenarios/astm/netrid/v19/dss/isa_subscription_interactions.md

               If that ISA cannot be deleted, the **[astm.f3411.v19.DSS0030,d](../../../../../requirements/astm/f3411/v19.md)** requirement to implement the ISA deletion endpoint might not be met.
-              #### Response to the deletion of the ISA contains subscription ID check
+              #### 🛑 Response to the deletion of the ISA contains subscription ID check

Contributor Author

the-glu Jan 15, 2025

This one can probably be moved to Medium?

monitoring/uss_qualifier/scenarios/astm/netrid/v22a/dss/isa_subscription_interactions.md

               If that ISA cannot be deleted, the **[astm.f3411.v22a.DSS0030,d](../../../../../requirements/astm/f3411/v22a.md)** requirement to implement the ISA deletion endpoint might not be met.
-              #### Response to the deletion of the ISA contains subscription ID check
+              #### 🛑 Response to the deletion of the ISA contains subscription ID check

Contributor Author

the-glu Jan 15, 2025

This one can probably be moved to Medium?

monitoring/uss_qualifier/scenarios/astm/netrid/v22a/dss/isa_subscription_interactions.md

               If the ISA cannot be mutated, **[astm.f3411.v22a.DSS0030,a](../../../../../requirements/astm/f3411/v22a.md)** is likely not implemented correctly.
-              #### Response to the mutation of the ISA contains subscription ID check
+              #### 🛑 Response to the mutation of the ISA contains subscription ID check

Contributor Author

the-glu Jan 15, 2025

This one can probably be moved to Medium?

monitoring/uss_qualifier/scenarios/astm/netrid/v22a/dss/isa_subscription_interactions.md

               If that ISA cannot be deleted, the **[astm.f3411.v22a.DSS0030,d](../../../../../requirements/astm/f3411/v22a.md)** requirement to implement the ISA deletion endpoint might not be met.
-              #### Response to the deletion of the ISA contains subscription ID check
+              #### 🛑 Response to the deletion of the ISA contains subscription ID check

Contributor Author

the-glu Jan 15, 2025

This one can probably be moved to Medium?

monitoring/uss_qualifier/scenarios/astm/netrid/v22a/dss/isa_simple.md Outdated

               The ISA search parameters are valid, as such the search should be successful.  If the request is not successful, this check will fail as per **[interuss.f3411.dss_endpoints.SearchISAs](../../../../../requirements/interuss/f3411/dss_endpoints.md)**.
-              #### ISA not returned by search check
+              #### 🛑 ISA not returned by search check

Contributor Author

the-glu Jan 15, 2025

This one can probably be moved to Medium?

monitoring/uss_qualifier/scenarios/astm/netrid/v22a/dss/isa_subscription_interactions.md

               The DSS should allow the creation of a subscription within the ISA footprint, otherwise it is in violation of **[astm.f3411.v22a.DSS0030,c](../../../../../requirements/astm/f3411/v22a.md)**
-              #### Subscription for the ISA's area mentions the ISA check
+              #### 🛑 Subscription for the ISA's area mentions the ISA check

Contributor Author

the-glu Jan 15, 2025

This one can probably be moved to Medium?

monitoring/uss_qualifier/scenarios/astm/netrid/v22a/dss/isa_subscription_interactions.md

               A subscription that is created for a volume that intersects with the previously created ISA should mention
               the previously created ISA. If not, the serving DSS is in violation of **[astm.f3411.v22a.DSS0030,c](../../../../../requirements/astm/f3411/v22a.md)**.
-              #### Newly created subscription has a notification_index of 0 check
+              #### 🛑 Newly created subscription has a notification_index of 0 check

Contributor Author

the-glu Jan 15, 2025

This one can probably be moved to Medium?

monitoring/uss_qualifier/scenarios/astm/netrid/v22a/dss/isa_subscription_interactions.md

               The DSS should allow a valid mutation of a subscription's area, otherwise it is in violation of **[astm.f3411.v22a.DSS0030,c](../../../../../requirements/astm/f3411/v22a.md)**
-              #### Subscription for the ISA's area mentions the ISA check
+              #### 🛑 Subscription for the ISA's area mentions the ISA check

Contributor Author

the-glu Jan 15, 2025

This one can probably be moved to Medium?

monitoring/uss_qualifier/scenarios/astm/netrid/v22a/dss/isa_subscription_interactions.md

               A subscription that is created for a volume that intersects with the previously created ISA should mention
               the previously created ISA. If not, the serving DSS is in violation of **[astm.f3411.v22a.DSS0030,c](../../../../../requirements/astm/f3411/v22a.md)**.
-              #### Mutated subscription has a notification_index of 0 check
+              #### 🛑 Mutated subscription has a notification_index of 0 check

Contributor Author

the-glu Jan 15, 2025

This one can probably be moved to Medium?


          [uss_qualifier/scenarios/netrid/dss/isa_subscription_interactions] sp…

51fa7d5

…ecify some check severity in test scenario documentation only (contrib interuss#404)

the-glu force-pushed the move-severity-check-2 branch from f36ba64 to 51fa7d5 Compare

January 16, 2025 11:09

the-glu marked this pull request as ready for review

January 16, 2025 11:10

BenjaminPelletier approved these changes

View reviewed changes

Member

BenjaminPelletier left a comment

I haven't reviewed each instance, but I would recommend going ahead and changing to Medium-severity each instance where you think it's justified. The likely worst-case outcome is that users see additional failures caused by the first failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet