refactor: Extract app version from project apps instead of relx config #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `get_app_version/1` to retrieve the version from the first project app's `.app.src` file using `rebar_app_info:original_vsn/1`. This provides the actual resolved version rather than symbolic references like `semver` or `git` that may be present in relx configuration. Remove `get_version_from_relx/1` helper function and simplified `normalize_version/1` by removing atom handling for symbolic refs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
get_app_version/1to retrieve the version from the first project app's.app.srcfile usingrebar_app_info:original_vsn/1. This provides the actual resolved version rather than symbolic references likesemverorgitthat may be present in relx configuration.Remove
get_version_from_relx/1helper function and simplifiednormalize_version/1by removing atom handling for symbolic refs.