Add isset check to prevent undefined index when Content-Type header #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR fixes the "Content-Type on null" error in LogAPIResponseToLog() by adding an isset() check before accessing the Content-Type header. Tested on v6.2.0 — verified that API response logging now works correctly even when the Content-Type header is missing or has unexpected values. Issue: #555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced an issue where LogAPIResponseToLog() threw "Content-Type on null" and
null comparison errors because it assumed the Content-Type header was
always present.
This fix adds an isset() check before accessing the Content-Type key,
so XML parsing is only attempted when the header exists.
With this change, API response logging no longer breaks when the
Content-Type header is missing or has unexpected values, making it
safer and more reliable.