Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: applied controls creation from risk scenario edit view #1232

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

Mohamed-Hacene
Copy link
Collaborator

No description provided.

@Mohamed-Hacene Mohamed-Hacene changed the title feat: check serializer data before scenario perform write method hotfix: applied controls creation from risk scenario edit view Dec 23, 2024
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we create an applied control from a scenario, the validated data only contains the applied control created, not the risk assessment so an error occured

Copy link
Contributor

@nas-tabchiche nas-tabchiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging

@nas-tabchiche nas-tabchiche merged commit a2583c4 into main Dec 23, 2024
17 checks passed
@nas-tabchiche nas-tabchiche deleted the hotfix/add-applied-control-in-risk-scenario branch December 23, 2024 16:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants