-
Notifications
You must be signed in to change notification settings - Fork 418
chore: update checkbox and radio class styles #2152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes simplify the styling of checkbox and radio components in the CSS by removing all custom utility styles, including their various states and interactions. Instead, a single rule is added to set the background color for both Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
frontend/src/app.css (1)
66-70
: Consider applying Forms plugin utilities for complete state supportThe new rule only sets a static background. Tailwind’s Forms plugin provides built-in sizing, borders, focus rings, hover and checked indicators. Verify that
.checkbox
and.radio
still render accessibly in all states, or optionally refactor:.checkbox { - background-color: var(--color-surface-100); + @apply form-checkbox bg-surface-100; } .radio { - background-color: var(--color-surface-100); + @apply form-radio bg-surface-100; }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
frontend/src/app.css
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (14)
- GitHub Check: enterprise-migrations-check (3.12)
- GitHub Check: migrations-check (3.12)
- GitHub Check: enterprise-startup-functional-test (3.12)
- GitHub Check: enterprise-startup-docker-compose-test
- GitHub Check: startup-functional-test (3.12)
- GitHub Check: startup-docker-compose-test
- GitHub Check: functional-tests (3.12, chromium)
- GitHub Check: enterprise-functional-tests (3.12, chromium)
- GitHub Check: build (22)
- GitHub Check: build (22)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (actions)
- GitHub Check: Analyze (python)
- GitHub Check: build (22)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary by CodeRabbit