Ca 519 move from local items to safe translate to translate dynamic strings #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monsieurswag
force-pushed
the
CA-519-Move-from-localItems-to-safeTranslate-to-translate-dynamic-strings
branch
from
2044727 to
304e719
Compare
|
This PR will surely cause a few silent translation errors but it's necessary to make the code cleaner |
monsieurswag
requested review from
nas-tabchiche and
Mohamed-Hacene
and removed request for
nas-tabchiche
Mohamed-Hacene
deleted the
CA-519-Move-from-localItems-to-safeTranslate-to-translate-dynamic-strings
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.