Improved error handling when license expiration is unset #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -203,8 +203,11 @@ def get_build(request): | |||
| LICENSE_SEATS = settings.LICENSE_SEATS | |||
| LICENSE_EXPIRATION = settings.LICENSE_EXPIRATION | |||
| try: | |||
| expiration_iso = datetime.fromisoformat(LICENSE_EXPIRATION) | |||
| license_expiration = date_format(expiration_iso, use_l10n=True) | |||
| if LICENSE_EXPIRATION and LICENSE_EXPIRATION.lower() != "unset": | |||
There was a problem hiding this comment.
I would advise to wrap the date cast in a try/except block, instead of explicitly checking for an "unset" string.
| expiration_iso = datetime.fromisoformat(LICENSE_EXPIRATION) | ||
| license_expiration = date_format(expiration_iso, use_l10n=True) | ||
| else: | ||
| license_expiration = "No expiration date set" |
There was a problem hiding this comment.
We should have an error identifier here instead of an english string, e.g. "noExpirationDateSet". This would make it easier to translate it in the frontend.
Mohamed-Hacene
previously requested changes
Oct 24, 2024
…xpiration-is-unset
…xpiration-is-unset
nas-tabchiche
force-pushed
the
CA-550-improve-error-handling-when-license-expiration-is-unset
branch
from
fdb8aad to
af7143a
Compare
nas-tabchiche
deleted the
CA-550-improve-error-handling-when-license-expiration-is-unset
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving the error handling when license expiration is unset by catching error when licence_expiracy = "unset"