perf(models): change extra_data to JSONB
#360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palkerecsenyi
force-pushed
the
jsonb
branch
2 times, most recently
from
50709cb to
ec48cd9
Compare
palkerecsenyi
force-pushed
the
jsonb
branch
from
ec48cd9 to
80d7395
Compare
12 tasks
palkerecsenyi
force-pushed
the
jsonb
branch
from
80d7395 to
826af3a
Compare
This was referenced Sep 25, 2025
palkerecsenyi
force-pushed
the
jsonb
branch
4 times, most recently
from
62e33fd to
575443e
Compare
ntarocco
reviewed
Nov 3, 2025
invenio_oauthclient/__init__.py
Outdated
| from .proxies import current_oauthclient | ||
|
|
||
| __version__ = "5.3.1" | ||
| __version__ = "5.4.0" |
Contributor
There was a problem hiding this comment.
Unfortunately, we need to consider this a breaking change and bump it to v6, otherwise this version will be installed in InvenioRDM v13 without running the Alembic recipe.
Can you please change it?
Can you please add a line explaining this in the vNext in the docs repo? Ty!
Member
Author
There was a problem hiding this comment.
Sounds good, will do. I guess we can aim to also include #328 in 6.0.0? So I will include docs for both in the vNext release notes.
Contributor
There was a problem hiding this comment.
Sounds good, will do. I guess we can aim to also include #328 in 6.0.0? So I will include docs for both in the
vNextrelease notes.
Yes, because it has a DB upgrade, so it is not a transparent installation that only requires to update the dependencies' versions.
Member
Author
There was a problem hiding this comment.
I've updated the version and added the docs here inveniosoftware/docs-invenio-rdm#884
palkerecsenyi
added a commit
to palkerecsenyi/docs-invenio-rdm
that referenced
this pull request
Nov 3, 2025
* `JSONB` is a newer and more efficient format for storing JSON in PostgreSQL. Compared to `JSON`, it offers significantly faster querying and indexing support (but is very slightly slower to input). The JSON is decomposed into a binary format rather than being stored in plaintext. * From a high-level perspective, the access of the data is unchanged in Python so this is not a breaking change. However, the new column type supports more querying operations which could be used in the future. * Migrating the column type is quite easy for small tables but can cause performance and stability issues for larger ones. Therefore, a default Alembic migration has been included for the vast majority of use cases, as well as a step-by-step alternative guide for larger instances. Instances with more than ~50k rows in `oauthclient_remoteaccount` are advised not to use the Alembic migration and to instead follow the upgrade guide.
palkerecsenyi
added a commit
to mesemus/invenio-oauthclient
that referenced
this pull request
Nov 3, 2025
* This matches up with inveniosoftware#360 which we are aiming to release at the same time
10 tasks
ntarocco
approved these changes
Nov 3, 2025
github-project-automation
bot
moved this from In review 🔍
to To release 🤖
in Sprint Q4/2025
palkerecsenyi
added a commit
to palkerecsenyi/invenio-app-rdm
that referenced
this pull request
Nov 3, 2025
* Bumping the major version of invenio-oauthclient to 6.0.0 * This includes inveniosoftware/invenio-oauthclient#360 which is not necessarily breaking but requires a manual DB migration for very large instances, as documented in the module's upgrade guide. * Further changes are yet come in v6 before RDM v14, such as inveniosoftware/invenio-oauthclient#328.
palkerecsenyi
added a commit
to palkerecsenyi/invenio-users-resources
that referenced
this pull request
Nov 4, 2025
* Bumping the major version of invenio-oauthclient to 6.0.0 * This includes inveniosoftware/invenio-oauthclient#360 which is not necessarily breaking but requires a manual DB migration for very large instances, as documented in the module's upgrade guide. * Further changes are yet come in v6 before RDM v14, such as inveniosoftware/invenio-oauthclient#328.
palkerecsenyi
added a commit
to palkerecsenyi/invenio-users-resources
that referenced
this pull request
Nov 4, 2025
* Bumping the major version of invenio-oauthclient to 6.0.0 * This includes inveniosoftware/invenio-oauthclient#360 which is not necessarily breaking but requires a manual DB migration for very large instances, as documented in the module's upgrade guide. * Further changes are yet come in v6 before RDM v14, such as inveniosoftware/invenio-oauthclient#328.
palkerecsenyi
added a commit
to palkerecsenyi/invenio-vcs
that referenced
this pull request
Nov 4, 2025
* Bumping the major version of invenio-oauthclient to 6.0.0 * This includes inveniosoftware/invenio-oauthclient#360 which is not necessarily breaking but requires a manual DB migration for very large instances, as documented in the module's upgrade guide. * Further changes are yet come in v6 before RDM v14, such as inveniosoftware/invenio-oauthclient#328.
palkerecsenyi
added a commit
to palkerecsenyi/invenio-app-rdm
that referenced
this pull request
Nov 4, 2025
* Bumping the major version of invenio-oauthclient to 6.0.0 * This includes inveniosoftware/invenio-oauthclient#360 which is not necessarily breaking but requires a manual DB migration for very large instances, as documented in the module's upgrade guide. * Further changes are yet come in v6 before RDM v14, such as inveniosoftware/invenio-oauthclient#328.
palkerecsenyi
added a commit
to palkerecsenyi/invenio-app-rdm
that referenced
this pull request
Nov 4, 2025
* Bumping the major version of invenio-oauthclient to 6.0.0 * This includes inveniosoftware/invenio-oauthclient#360 which is not necessarily breaking but requires a manual DB migration for very large instances, as documented in the module's upgrade guide. * Further changes are yet come in v6 before RDM v14, such as inveniosoftware/invenio-oauthclient#328.
palkerecsenyi
added a commit
to palkerecsenyi/invenio-app-rdm
that referenced
this pull request
Nov 4, 2025
* Bumping the major version of invenio-oauthclient to 6.0.0 * This includes inveniosoftware/invenio-oauthclient#360 which is not necessarily breaking but requires a manual DB migration for very large instances, as documented in the module's upgrade guide. * Further changes are yet come in v6 before RDM v14, such as inveniosoftware/invenio-oauthclient#328.
Member
Author
palkerecsenyi
added a commit
to palkerecsenyi/invenio-app-ils
that referenced
this pull request
Nov 5, 2025
* Bumping the major version of invenio-oauthclient to 6.0.0 * This includes inveniosoftware/invenio-oauthclient#360 which is not necessarily breaking but requires a manual DB migration for very large instances, as documented in the module's upgrade guide. * Further changes are yet come in v6 before RDM v14, such as inveniosoftware/invenio-oauthclient#328.
palkerecsenyi
added a commit
to palkerecsenyi/invenio-app-ils
that referenced
this pull request
Nov 5, 2025
* Bumping the major version of invenio-oauthclient to 6.0.0 * This includes inveniosoftware/invenio-oauthclient#360 which is not necessarily breaking but requires a manual DB migration for very large instances, as documented in the module's upgrade guide. * Further changes are yet come in v6, such as inveniosoftware/invenio-oauthclient#328.
palkerecsenyi
added a commit
to palkerecsenyi/invenio-app-rdm
that referenced
this pull request
Nov 6, 2025
* Bumping the major version of invenio-oauthclient to 6.0.0 * This includes inveniosoftware/invenio-oauthclient#360 which is not necessarily breaking but requires a manual DB migration for very large instances, as documented in the module's upgrade guide. * Further changes are yet come in v6 before RDM v14, such as inveniosoftware/invenio-oauthclient#328.
palkerecsenyi
added a commit
to palkerecsenyi/invenio-app-rdm
that referenced
this pull request
Nov 6, 2025
* Bumping the major version of invenio-oauthclient to 6.0.0 * This includes inveniosoftware/invenio-oauthclient#360 which is not necessarily breaking but requires a manual DB migration for very large instances, as documented in the module's upgrade guide. * Further changes are yet come in v6 before RDM v14, such as inveniosoftware/invenio-oauthclient#328.
palkerecsenyi
added a commit
to palkerecsenyi/invenio-app-rdm
that referenced
this pull request
Nov 6, 2025
* Bumping the major version of invenio-oauthclient to 6.0.0 * This includes inveniosoftware/invenio-oauthclient#360 which is not necessarily breaking but requires a manual DB migration for very large instances, as documented in the module's upgrade guide. * Further changes are yet come in v6 before RDM v14, such as inveniosoftware/invenio-oauthclient#328.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related (vaguely) to inveniosoftware/invenio-github#190, but is not a dependency.
Important: we are aiming to release this at the same time as #328. When we merge, we need to align the DB migrations, but still keep them as 2 separate migrations so this one can be run manually. The other migration does not need to be run manually in any scenario.
JSONBis a newer and more efficient format for storing JSON in PostgreSQL. Compared toJSON, it offers significantly faster querying and indexing support (but is very slightly slower to input). The JSON is decomposed into a binary format rather than being stored in plaintext.From a high-level perspective, the access of the data is unchanged in Python so this is not a breaking change. However, the new column type supports more querying operations which could be used in the future.
Migrating the column type is quite easy for small tables but can cause performance and stability issues for larger ones. Therefore, a default Alembic migration has been included for the vast majority of use cases, as well as a step-by-step alternative guide for larger instances. Instances with more than ~50k rows in
oauthclient_remoteaccountare advised not to use the Alembic migration and to instead follow the upgrade guide.