Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve main entry path relative to project directory #123

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

codekeyz
Copy link
Collaborator

@codekeyz codekeyz commented Dec 13, 2024

This fixes issue for mono-repos where Globe CLI is run from root directory, but project directory isn't root directory.

serverpod_project 
  - serverpod_client
  - serverpod_flutter
  - serverpod_server (actual project directory)

Resolving main entry should return bin/main.dart instead of serverpod_server/bin/main.dart since serverpod_server is already our working directory.

@codekeyz codekeyz requested a review from kaziwaseef December 13, 2024 14:50
@codekeyz codekeyz self-assigned this Dec 13, 2024
@codekeyz codekeyz added the enhancement New feature or request label Dec 13, 2024
@codekeyz codekeyz merged commit 01d2978 into main Dec 13, 2024
9 checks passed
@codekeyz codekeyz deleted the fix/resolve-entry-point-for-mono-repos branch December 13, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants