Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ios credentials setup instructions #8251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

romanakash
Copy link

Description

Update documentation for adding ios credentials

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2025 0:32am

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2025

CLA assistant check
All committers have signed the CLA.

@enchorb
Copy link

enchorb commented Jan 26, 2025

Is it possible to also update the setup guide for the messaging module, https://rnfirebase.io/messaging/usage, more specifcally the section To inject a isHeadless prop into your app, please update your AppDelegate.m file as instructed below:

Copy link
Contributor

@wneel wneel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed my build on react-native@0.77.1 (iOS), thanks

At the top of the file, import the Firebase SDK right after `'import ReactAppDependencyProvider'`:

```
#import Firebase

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#import Firebase
import Firebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants