-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(app, expo): improve messaging for expo development build users #8310
base: main
Are you sure you want to change the base?
Conversation
The previous messaging was a bit confusing since the problem is not with Expo Go, but rather Expo development builds. Context: Expo development build = a customized version of "Expo Go" where developers add "react-native" libraries (e.g. `react-native-firebase`) and recompile the "react-native" layer of the mobile app using XCode and/or Android Studio. Expo Go contains a pre-compiled "react-native" layer that cannot be changed unless done so by Expo
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I see the difference, and your version is more helpful, thank you. CI is very opinionated on formatting and spelling but I can push it through from here with little amendments if needed
Will need the CLA signed though, even for docs things :-) - if you follow the details link it'll step you through if you haven't already |
@raxng would love to merge this but need the CLA signed if you have a moment? Thanks! |
The previous messaging was a bit confusing since the problem is not with Expo Go, but rather Expo development builds.
Context:
Expo development build = a customized version of "Expo Go" where developers add "react-native" libraries (e.g.
react-native-firebase
) and recompile the "react-native" layer of the mobile app using XCode and/or Android Studio.Expo Go contains a pre-compiled "react-native" layer that cannot be changed unless done so by Expo
Description
Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
N/A
React Native Firebase
andInvertase
on Twitter