Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(app, expo): improve messaging for expo development build users #8310

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

raxng
Copy link

@raxng raxng commented Feb 9, 2025

The previous messaging was a bit confusing since the problem is not with Expo Go, but rather Expo development builds.

Context:
Expo development build = a customized version of "Expo Go" where developers add "react-native" libraries (e.g. react-native-firebase) and recompile the "react-native" layer of the mobile app using XCode and/or Android Studio.

Expo Go contains a pre-compiled "react-native" layer that cannot be changed unless done so by Expo

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • ✅ Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • ✅ No

Test Plan

N/A

The previous messaging was a bit confusing since the problem is not with Expo Go, but rather Expo development builds.

Context:
Expo development build = a customized version of "Expo Go" where developers add "react-native" libraries (e.g. `react-native-firebase`) and recompile the "react-native" layer of the mobile app using XCode and/or Android Studio.

Expo Go contains a pre-compiled "react-native" layer that cannot be changed unless done so by Expo
Copy link

vercel bot commented Feb 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 9:09pm

@CLAassistant
Copy link

CLAassistant commented Feb 9, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mikehardy
❌ raxng
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I see the difference, and your version is more helpful, thank you. CI is very opinionated on formatting and spelling but I can push it through from here with little amendments if needed

@mikehardy
Copy link
Collaborator

Will need the CLA signed though, even for docs things :-) - if you follow the details link it'll step you through if you haven't already

@mikehardy mikehardy closed this Feb 9, 2025
@mikehardy mikehardy reopened this Feb 9, 2025
@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Feb 9, 2025
@mikehardy mikehardy changed the title docs(expo): improve messaging for expo development build users docs(app, expo): improve messaging for expo development build users Feb 9, 2025
@mikehardy
Copy link
Collaborator

@raxng would love to merge this but need the CLA signed if you have a moment? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants