fix(analytics): Type defs #8363
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MichaelVerdon
changed the title
MichaelVerdon
changed the title
MichaelVerdon
changed the title
| * @returns {string} | ||
| */ | ||
| export function getGoogleAnalyticsClientId(analytics) { | ||
| throw new Error('getGoogleAnalyticsClientId is web-only and not yet supported.'); |
There was a problem hiding this comment.
for web we have an implementation already (I'm aware because I was in there semi-recently - it works...)
if you haven't done it, running yarn tests:macos:pod:install && yarn tests:macos:build && yarn tests:macos:test-cover runs the "web" version, and if you put an it.only or describe.only on any part of the e2e suite it'll run just those so it's fast to test+iterate
shame not to expose it since that might be half the work that went into the "other" platform analytics!
| */ | ||
| export function getGoogleAnalyticsClientId(analytics) { | ||
| throw new Error('getGoogleAnalyticsClientId is web-only and not yet supported.'); | ||
| return analytics; |
There was a problem hiding this comment.
...but, @returns {string} 🤔 ?
There was a problem hiding this comment.
This was put there temporarily so the linter wouldn't get angry at me.
Description
Related issues
Release Summary
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter