-
Notifications
You must be signed in to change notification settings - Fork 75
fix(ci): try to make CI less flaky #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/tanstack-query-firebase~209 Documentation is deployed and generated using docs.page. |
1d7bc4a
to
419d373
Compare
419d373
to
ead83cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates project configuration to use demo-test-project
instead of test-project
for Firebase emulator testing and CI workflows. This change ensures consistency across all configuration files and testing environments.
- Standardizes Firebase project ID across all package.json scripts, test utilities, and configuration files
- Adds Data Connect SDK generation step to CI workflows before running emulator tests
- Reorganizes generated SDK exports by moving query functions after mutation functions
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/react/vitest/utils.ts | Updates test project ID in Firebase config and emulator URLs |
packages/react/package.json | Changes emulator script to use new project ID |
package.json | Updates test and emulator scripts with new project ID |
firebase.json | Adds host configuration for dataconnect emulator |
examples/react/useGetIdTokenQuery/package.json | Updates dev:emulator script with new project ID |
dataconnect-sdk/js/default-connector/index.cjs.js | Reorganizes exports by moving query functions after mutations |
dataconnect-sdk/js/default-connector/esm/index.esm.js | Reorganizes exports by moving query functions after mutations |
.github/workflows/tests.yaml | Adds Data Connect SDK generation step before running tests |
.github/workflows/repro.yml | New workflow file for reproduction testing with dataconnect emulator |
.github/workflows/release.yml | Adds SDK generation step and removes some comments |
.github/workflows/local-ci.yml | Adds SDK generation step and removes comment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Updates project configuration to use demo-test-project instead of test-project for Firebase emulator testing and CI workflows. This change ensures consistency across all configuration files and testing environments.