Skip to content

Conversation

cabljac
Copy link
Collaborator

@cabljac cabljac commented Aug 19, 2025

Updates project configuration to use demo-test-project instead of test-project for Firebase emulator testing and CI workflows. This change ensures consistency across all configuration files and testing environments.

  • Standardizes Firebase project ID across all package.json scripts, test utilities, and configuration files
  • Adds Data Connect SDK generation step to CI workflows before running emulator tests
  • Reorganizes generated SDK exports by moving query functions after mutation functions

Copy link

changeset-bot bot commented Aug 19, 2025

⚠️ No Changeset found

Latest commit: 2586107

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

docs-page bot commented Aug 19, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/tanstack-query-firebase~209

Documentation is deployed and generated using docs.page.

@cabljac cabljac force-pushed the @invertase/fix-CI branch 3 times, most recently from 1d7bc4a to 419d373 Compare August 19, 2025 09:37
@cabljac cabljac force-pushed the @invertase/fix-CI branch from 419d373 to ead83cd Compare August 19, 2025 10:08
@cabljac cabljac requested a review from Copilot August 26, 2025 09:45
@cabljac cabljac changed the title @invertase/fix ci fix(ci): try to make CI less flaky Aug 26, 2025
@cabljac cabljac marked this pull request as ready for review August 26, 2025 09:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates project configuration to use demo-test-project instead of test-project for Firebase emulator testing and CI workflows. This change ensures consistency across all configuration files and testing environments.

  • Standardizes Firebase project ID across all package.json scripts, test utilities, and configuration files
  • Adds Data Connect SDK generation step to CI workflows before running emulator tests
  • Reorganizes generated SDK exports by moving query functions after mutation functions

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/react/vitest/utils.ts Updates test project ID in Firebase config and emulator URLs
packages/react/package.json Changes emulator script to use new project ID
package.json Updates test and emulator scripts with new project ID
firebase.json Adds host configuration for dataconnect emulator
examples/react/useGetIdTokenQuery/package.json Updates dev:emulator script with new project ID
dataconnect-sdk/js/default-connector/index.cjs.js Reorganizes exports by moving query functions after mutations
dataconnect-sdk/js/default-connector/esm/index.esm.js Reorganizes exports by moving query functions after mutations
.github/workflows/tests.yaml Adds Data Connect SDK generation step before running tests
.github/workflows/repro.yml New workflow file for reproduction testing with dataconnect emulator
.github/workflows/release.yml Adds SDK generation step and removes some comments
.github/workflows/local-ci.yml Adds SDK generation step and removes comment

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant